aboutsummaryrefslogtreecommitdiff
path: root/include/qemu-io.h
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2023-05-22 14:04:40 -0500
committerEric Blake <eblake@redhat.com>2023-06-02 12:29:27 -0500
commitc25b1683443c6d658a82dc1c5587fdb0ae81663c (patch)
treee3d39baf7ced7022ba54e65943c970d63721443f /include/qemu-io.h
parentb87ac96651054fa89baab4e3a88a7feee7f92314 (diff)
downloadqemu-c25b1683443c6d658a82dc1c5587fdb0ae81663c.zip
qemu-c25b1683443c6d658a82dc1c5587fdb0ae81663c.tar.gz
qemu-c25b1683443c6d658a82dc1c5587fdb0ae81663c.tar.bz2
cutils: Improve qemu_strtod* error paths
Previous patches changed all integral qemu_strto*() error paths to guarantee that *value is never left uninitialized. Do likewise for qemu_strtod. Also, tighten qemu_strtod_finite() to never return a non-finite value (prior to this patch, we were rejecting "inf" with -EINVAL and unspecified result 0.0, but failing "9e999" with -ERANGE and HUGE_VAL - which is infinite on IEEE machines - despite our function claiming to recognize only finite values). Auditing callers, we have no external callers of qemu_strtod, and among the callers of qemu_strtod_finite: - qapi/qobject-input-visitor.c:qobject_input_type_number_keyval() and qapi/string-input-visitor.c:parse_type_number() which reject all errors (does not matter what we store) - utils/cutils.c:do_strtosz() incorrectly assumes that *endptr points to '.' on all failures (that is, it is not distinguishing between EINVAL and ERANGE; and therefore still does the WRONG THING for "9.9e999". The change here does not entirely fix that (a later patch will tackle this more systematically), but at least it fixes the read-out-of-bounds first diagnosed in https://gitlab.com/qemu-project/qemu/-/issues/1629 - our testsuite, which we can update to match what we document Signed-off-by: Eric Blake <eblake@redhat.com> Reviewed-by: Hanna Czenczek <hreitz@redhat.com> CC: qemu-stable@nongnu.org Message-Id: <20230522190441.64278-19-eblake@redhat.com>
Diffstat (limited to 'include/qemu-io.h')
0 files changed, 0 insertions, 0 deletions