diff options
author | Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | 2021-12-23 17:01:29 +0100 |
---|---|---|
committer | Hanna Reitz <hreitz@redhat.com> | 2022-02-01 10:51:39 +0100 |
commit | 22e29bcea12ccf0e127b91917d959c69bebbd952 (patch) | |
tree | 146152b01db7531e6e67ca92a39dd2caa6eb7ad8 /include/hw | |
parent | b30b8077243ea5dc93a540eedfecee3c74b19fa2 (diff) | |
download | qemu-22e29bcea12ccf0e127b91917d959c69bebbd952.zip qemu-22e29bcea12ccf0e127b91917d959c69bebbd952.tar.gz qemu-22e29bcea12ccf0e127b91917d959c69bebbd952.tar.bz2 |
iotests.py: qemu_img*("create"): support IMGOPTS='compression_type=zstd'
Adding support of IMGOPTS (like in bash tests) allows user to pass a
lot of different options. Still, some may require additional logic.
Now we want compression_type option, so add some smart logic around it:
ignore compression_type=zstd in IMGOPTS, if test want qcow2 in
compatibility mode. As well, ignore compression_type for non-qcow2
formats.
Note that we may instead add support only to qemu_img_create(), but
that works bad:
1. We'll have to update a lot of tests to use qemu_img_create instead
of qemu_img('create'). (still, we may want do it anyway, but no
reason to create a dependancy between task of supporting IMGOPTS and
updating a lot of tests)
2. Some tests use qemu_img_pipe('create', ..) - even more work on
updating
3. Even if we update all tests to go through qemu_img_create, we'll
need a way to avoid creating new tests using qemu_img*('create') -
add assertions.. That doesn't seem good.
So, let's add support of IMGOPTS to most generic
qemu_img_pipe_and_status().
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20211223160144.1097696-5-vsementsov@virtuozzo.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Diffstat (limited to 'include/hw')
0 files changed, 0 insertions, 0 deletions