diff options
| author | Cédric Le Goater <clg@kaod.org> | 2023-09-18 16:58:43 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2023-09-29 10:07:17 +0200 |
| commit | 90231ce1a355ce07b71f9b82446a40ac866585de (patch) | |
| tree | 81081aba229701fda825c15e8919a0bae98ee8f1 /include/hw | |
| parent | 1cc0c5dd38884a7c54bc806bb0ae182db275faf0 (diff) | |
| download | qemu-90231ce1a355ce07b71f9b82446a40ac866585de.zip qemu-90231ce1a355ce07b71f9b82446a40ac866585de.tar.gz qemu-90231ce1a355ce07b71f9b82446a40ac866585de.tar.bz2 | |
hw/ppc: Clean up local variable shadowing in _FDT helper routine
this fixes numerous warnings of this type :
In file included from ../hw/ppc/spapr_pci.c:43:
../hw/ppc/spapr_pci.c: In function ‘spapr_dt_phb’:
../include/hw/ppc/fdt.h:18:13: warning: declaration of ‘ret’ shadows a previous local [-Wshadow=compatible-local]
18 | int ret = (exp); \
| ^~~
../hw/ppc/spapr_pci.c:2355:5: note: in expansion of macro ‘_FDT’
2355 | _FDT(bus_off = fdt_add_subnode(fdt, 0, phb->dtbusname));
| ^~~~
../hw/ppc/spapr_pci.c:2311:24: note: shadowed declaration is here
2311 | int bus_off, i, j, ret;
| ^~~
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Message-ID: <20230918145850.241074-2-clg@kaod.org>
Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'include/hw')
| -rw-r--r-- | include/hw/ppc/fdt.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/include/hw/ppc/fdt.h b/include/hw/ppc/fdt.h index a8cd850..b56ac2a 100644 --- a/include/hw/ppc/fdt.h +++ b/include/hw/ppc/fdt.h @@ -15,10 +15,10 @@ #define _FDT(exp) \ do { \ - int ret = (exp); \ - if (ret < 0) { \ - error_report("error creating device tree: %s: %s", \ - #exp, fdt_strerror(ret)); \ + int _ret = (exp); \ + if (_ret < 0) { \ + error_report("error creating device tree: %s: %s", \ + #exp, fdt_strerror(_ret)); \ exit(1); \ } \ } while (0) |