diff options
| author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:50 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:31:52 +0200 |
| commit | db725815985654007ade0fd53590d613fd657208 (patch) | |
| tree | e39bcf77a808fa0002cea415b2a487cf5c7eaf4b /include/chardev | |
| parent | dc5e9ac716c5c5312ab29fb9f311f8176064fe04 (diff) | |
| download | qemu-db725815985654007ade0fd53590d613fd657208.zip qemu-db725815985654007ade0fd53590d613fd657208.tar.gz qemu-db725815985654007ade0fd53590d613fd657208.tar.bz2 | |
Include qemu/main-loop.h less
In my "build everything" tree, changing qemu/main-loop.h triggers a
recompile of some 5600 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h). It includes block/aio.h,
which in turn includes qemu/event_notifier.h, qemu/notify.h,
qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h,
qemu/thread.h, qemu/timer.h, and a few more.
Include qemu/main-loop.h only where it's needed. Touching it now
recompiles only some 1700 objects. For block/aio.h and
qemu/event_notifier.h, these numbers drop from 5600 to 2800. For the
others, they shrink only slightly.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190812052359.30071-21-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'include/chardev')
| -rw-r--r-- | include/chardev/char-fe.h | 1 | ||||
| -rw-r--r-- | include/chardev/char-io.h | 1 | ||||
| -rw-r--r-- | include/chardev/char.h | 2 |
3 files changed, 3 insertions, 1 deletions
diff --git a/include/chardev/char-fe.h b/include/chardev/char-fe.h index aa1b864..67601dc 100644 --- a/include/chardev/char-fe.h +++ b/include/chardev/char-fe.h @@ -2,6 +2,7 @@ #define QEMU_CHAR_FE_H #include "chardev/char.h" +#include "qemu/main-loop.h" typedef void IOEventHandler(void *opaque, int event); typedef int BackendChangeHandler(void *opaque); diff --git a/include/chardev/char-io.h b/include/chardev/char-io.h index 1709b59..ac379ea 100644 --- a/include/chardev/char-io.h +++ b/include/chardev/char-io.h @@ -26,6 +26,7 @@ #include "io/channel.h" #include "chardev/char.h" +#include "qemu/main-loop.h" /* Can only be used for read */ GSource *io_add_watch_poll(Chardev *chr, diff --git a/include/chardev/char.h b/include/chardev/char.h index c0b57f7..087b202 100644 --- a/include/chardev/char.h +++ b/include/chardev/char.h @@ -2,8 +2,8 @@ #define QEMU_CHAR_H #include "qapi/qapi-types-char.h" -#include "qemu/main-loop.h" #include "qemu/bitmap.h" +#include "qemu/thread.h" #include "qom/object.h" #define IAC_EOR 239 |