diff options
| author | Emanuele Giuseppe Esposito <eesposit@redhat.com> | 2023-01-13 21:42:10 +0100 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2023-02-01 16:52:32 +0100 |
| commit | 2c75261cc2b5d1cdd6f012d7a3ccbc089f966dcb (patch) | |
| tree | 55578b863cf3691236c88e52818ea3a0d6f4fad0 /include/block/block_int-common.h | |
| parent | 2531b390fbf67ceccf63f7d236ab2a998f135624 (diff) | |
| download | qemu-2c75261cc2b5d1cdd6f012d7a3ccbc089f966dcb.zip qemu-2c75261cc2b5d1cdd6f012d7a3ccbc089f966dcb.tar.gz qemu-2c75261cc2b5d1cdd6f012d7a3ccbc089f966dcb.tar.bz2 | |
block: Convert bdrv_lock_medium() to co_wrapper
bdrv_lock_medium() is categorized as an I/O function, and it currently
doesn't run in a coroutine. We should let it take a graph rdlock since
it traverses the block nodes graph, which however is only possible in a
coroutine.
The only caller of this function is blk_lock_medium(). Therefore make
blk_lock_medium() a co_wrapper, so that it always creates a new
coroutine, and then make bdrv_lock_medium() a coroutine_fn where the
lock can be taken.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20230113204212.359076-13-kwolf@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'include/block/block_int-common.h')
| -rw-r--r-- | include/block/block_int-common.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/block/block_int-common.h b/include/block/block_int-common.h index 4142966..64b05fd 100644 --- a/include/block/block_int-common.h +++ b/include/block/block_int-common.h @@ -709,7 +709,7 @@ struct BlockDriver { /* removable device specific */ bool coroutine_fn (*bdrv_co_is_inserted)(BlockDriverState *bs); void coroutine_fn (*bdrv_co_eject)(BlockDriverState *bs, bool eject_flag); - void (*bdrv_lock_medium)(BlockDriverState *bs, bool locked); + void coroutine_fn (*bdrv_co_lock_medium)(BlockDriverState *bs, bool locked); /* to control generic scsi devices */ BlockAIOCB *(*bdrv_aio_ioctl)(BlockDriverState *bs, |