diff options
| author | Markus Armbruster <armbru@redhat.com> | 2022-12-21 14:35:49 +0100 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2023-01-20 07:24:28 +0100 |
| commit | e2c1c34f139f49ef909bb4322607fb8b39002312 (patch) | |
| tree | 7bd8fcb9db4dd89d8edcd3d59e8c5f42f2e5f445 /include/block/block-common.h | |
| parent | 436956013539c19cf781ae333bc1c125d728cf1f (diff) | |
| download | qemu-e2c1c34f139f49ef909bb4322607fb8b39002312.zip qemu-e2c1c34f139f49ef909bb4322607fb8b39002312.tar.gz qemu-e2c1c34f139f49ef909bb4322607fb8b39002312.tar.bz2 | |
include/block: Untangle inclusion loops
We have two inclusion loops:
block/block.h
-> block/block-global-state.h
-> block/block-common.h
-> block/blockjob.h
-> block/block.h
block/block.h
-> block/block-io.h
-> block/block-common.h
-> block/blockjob.h
-> block/block.h
I believe these go back to Emanuele's reorganization of the block API,
merged a few months ago in commit d7e2fe4aac8.
Fortunately, breaking them is merely a matter of deleting unnecessary
includes from headers, and adding them back in places where they are
now missing.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221221133551.3967339-2-armbru@redhat.com>
Diffstat (limited to 'include/block/block-common.h')
| -rw-r--r-- | include/block/block-common.h | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/include/block/block-common.h b/include/block/block-common.h index 434ffc5..4168681 100644 --- a/include/block/block-common.h +++ b/include/block/block-common.h @@ -24,12 +24,8 @@ #ifndef BLOCK_COMMON_H #define BLOCK_COMMON_H -#include "block/aio.h" -#include "block/aio-wait.h" -#include "qemu/iov.h" -#include "block/accounting.h" -#include "qemu/hbitmap.h" -#include "qemu/transactions.h" +#include "qapi/qapi-types-block-core.h" +#include "qemu/queue.h" /* * co_wrapper{*}: Function specifiers used by block-coroutine-wrapper.py @@ -55,7 +51,6 @@ #define co_wrapper_bdrv_rdlock #define co_wrapper_mixed_bdrv_rdlock -#include "block/dirty-bitmap.h" #include "block/blockjob.h" /* block.c */ |