diff options
| author | Prasad J Pandit <pjp@fedoraproject.org> | 2016-12-14 12:31:56 +0530 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2016-12-20 14:18:39 +0100 |
| commit | abd7f08b2353f43274b785db8c7224f082ef4d31 (patch) | |
| tree | c4cea5bb772ab6e46b3966ca01cb7342a8eb07a7 /hw | |
| parent | 6a928d25b6d8bc3729c3d28326c6db13b9481059 (diff) | |
| download | qemu-abd7f08b2353f43274b785db8c7224f082ef4d31.zip qemu-abd7f08b2353f43274b785db8c7224f082ef4d31.tar.gz qemu-abd7f08b2353f43274b785db8c7224f082ef4d31.tar.bz2 | |
display: virtio-gpu-3d: check virgl capabilities max_size
Virtio GPU device while processing 'VIRTIO_GPU_CMD_GET_CAPSET'
command, retrieves the maximum capabilities size to fill in the
response object. It continues to fill in capabilities even if
retrieved 'max_size' is zero(0), thus resulting in OOB access.
Add check to avoid it.
Reported-by: Zhenhao Hong <zhenhaohong@gmail.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Message-id: 20161214070156.23368-1-ppandit@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/display/virtio-gpu-3d.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c index 23f39de..e29f099 100644 --- a/hw/display/virtio-gpu-3d.c +++ b/hw/display/virtio-gpu-3d.c @@ -371,8 +371,12 @@ static void virgl_cmd_get_capset(VirtIOGPU *g, virgl_renderer_get_cap_set(gc.capset_id, &max_ver, &max_size); - resp = g_malloc(sizeof(*resp) + max_size); + if (!max_size) { + cmd->error = VIRTIO_GPU_RESP_ERR_INVALID_PARAMETER; + return; + } + resp = g_malloc(sizeof(*resp) + max_size); resp->hdr.type = VIRTIO_GPU_RESP_OK_CAPSET; virgl_renderer_fill_caps(gc.capset_id, gc.capset_version, |