diff options
| author | Igor Mammedov <imammedo@redhat.com> | 2023-03-02 17:15:39 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2023-03-07 12:39:00 -0500 |
| commit | 419233b2b417eec65211b4a5160d94978546467b (patch) | |
| tree | a65f86de4bc846646593c4890e688ebab93a470e /hw | |
| parent | 041b1c40f38a63baff7c375d1e3df6f365aa5882 (diff) | |
| download | qemu-419233b2b417eec65211b4a5160d94978546467b.zip qemu-419233b2b417eec65211b4a5160d94978546467b.tar.gz qemu-419233b2b417eec65211b4a5160d94978546467b.tar.bz2 | |
acpi: pci: drop BSEL usage when deciding that device isn't hotpluggable
previous commit ("pci: fix 'hotplugglable' property behavior") fixed
pcie root port's 'hotpluggable' property to behave consistently.
So we don't need a BSEL crutch anymore to see of device is not
hotpluggable, drop it from 'generic' PCI slots description handling.
BSEL is still used to decide if hotplug part should be called
but that will be moved out of generic code to hotplug one by
followup patches.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20230302161543.286002-31-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/i386/acpi-build.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 8e2481f..ce14866 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -591,7 +591,7 @@ void build_append_pci_bus_devices(Aml *parent_scope, PCIBus *bus) call_dev_aml_func(DEVICE(bus->devices[devfn]), dev); /* add _DSM if device has acpi-index set */ - if (pdev->acpi_index && !bsel && + if (pdev->acpi_index && !object_property_get_bool(OBJECT(pdev), "hotpluggable", &error_abort)) { aml_append(dev, aml_pci_static_endpoint_dsm(pdev)); |