aboutsummaryrefslogtreecommitdiff
path: root/hw
diff options
context:
space:
mode:
authorBen Widawsky <ben.widawsky@intel.com>2020-10-15 11:14:10 -0700
committerMichael S. Tsirkin <mst@redhat.com>2020-10-30 06:48:53 -0400
commit2c729dc8ceaab88f213c7724de0fa181ffc7f078 (patch)
tree8946ba3e99c08e2aae74e25858fca3cca5f57940 /hw
parent4c70875372b821b045e84f462466a5c04b091ef5 (diff)
downloadqemu-2c729dc8ceaab88f213c7724de0fa181ffc7f078.zip
qemu-2c729dc8ceaab88f213c7724de0fa181ffc7f078.tar.gz
qemu-2c729dc8ceaab88f213c7724de0fa181ffc7f078.tar.bz2
pci: Change error_report to assert(3)
Asserts are used for developer bugs. As registering a bar of the wrong size is not something that should be possible for a user to achieve, this is a developer bug. While here, use the more obvious helper function. Signed-off-by: Ben Widawsky <ben.widawsky@intel.com> Message-Id: <20201015181411.89104-1-ben.widawsky@intel.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'hw')
-rw-r--r--hw/pci/pci.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index dc40198..e5b7c9a 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -1151,11 +1151,7 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num,
assert(region_num >= 0);
assert(region_num < PCI_NUM_REGIONS);
- if (size & (size-1)) {
- error_report("ERROR: PCI region size must be pow2 "
- "type=0x%x, size=0x%"FMT_PCIBUS"", type, size);
- exit(1);
- }
+ assert(is_power_of_2(size));
r = &pci_dev->io_regions[region_num];
r->addr = PCI_BAR_UNMAPPED;