diff options
| author | Yuval Shaia <yuval.shaia@oracle.com> | 2019-01-09 22:15:59 +0200 |
|---|---|---|
| committer | Marcel Apfelbaum <marcel.apfelbaum@gmail.com> | 2019-01-19 10:49:40 +0200 |
| commit | 26fd869556bb9513bf82ad9573c906b2a631576e (patch) | |
| tree | b5220ecf7c80862471870bfad189092d4bb4621a /hw | |
| parent | 732d948ca52d1a91a0930acfd7610598d4e78903 (diff) | |
| download | qemu-26fd869556bb9513bf82ad9573c906b2a631576e.zip qemu-26fd869556bb9513bf82ad9573c906b2a631576e.tar.gz qemu-26fd869556bb9513bf82ad9573c906b2a631576e.tar.bz2 | |
hw/pvrdma: Post CQE when receive invalid gid index
This error should propagate back to guest.
Spotted by Coverity: CID 1398595
Fixes: 2b05705dc8
Reported-by: Li Qiang <liq3ea@163.com>
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/rdma/rdma_backend.h | 1 | ||||
| -rw-r--r-- | hw/rdma/vmw/pvrdma_qp_ops.c | 6 |
2 files changed, 5 insertions, 2 deletions
diff --git a/hw/rdma/rdma_backend.h b/hw/rdma/rdma_backend.h index a9ba40a..5114c90 100644 --- a/hw/rdma/rdma_backend.h +++ b/hw/rdma/rdma_backend.h @@ -32,6 +32,7 @@ #define VENDOR_ERR_INVLKEY 0x207 #define VENDOR_ERR_MR_SMALL 0x208 #define VENDOR_ERR_INV_MAD_BUFF 0x209 +#define VENDOR_ERR_INV_GID_IDX 0x210 /* Add definition for QP0 and QP1 as there is no userspace enums for them */ enum ibv_special_qp_type { diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c index 465bee8..0565eba 100644 --- a/hw/rdma/vmw/pvrdma_qp_ops.c +++ b/hw/rdma/vmw/pvrdma_qp_ops.c @@ -178,7 +178,8 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle) sgid = rdma_rm_get_gid(&dev->rdma_dev_res, wqe->hdr.wr.ud.av.gid_index); if (!sgid) { pr_dbg("Fail to get gid for idx %d\n", wqe->hdr.wr.ud.av.gid_index); - return -EIO; + complete_with_error(VENDOR_ERR_INV_GID_IDX, comp_ctx); + continue; } pr_dbg("sgid_id=%d, sgid=0x%llx\n", wqe->hdr.wr.ud.av.gid_index, sgid->global.interface_id); @@ -189,7 +190,8 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle) if (sgid_idx <= 0) { pr_dbg("Fail to get bk sgid_idx for sgid_idx %d\n", wqe->hdr.wr.ud.av.gid_index); - return -EIO; + complete_with_error(VENDOR_ERR_INV_GID_IDX, comp_ctx); + continue; } if (wqe->hdr.num_sge > dev->dev_attr.max_sge) { |