diff options
| author | Marc-André Lureau <marcandre.lureau@redhat.com> | 2017-11-06 19:39:19 +0100 |
|---|---|---|
| committer | Stefan Berger <stefanb@linux.vnet.ibm.com> | 2017-12-14 23:39:15 -0500 |
| commit | 3d01141144583bd12b5d7c76326328e509a677ec (patch) | |
| tree | f0351cf0f13c8d66d23e387520fc4916bf5b1a45 /hw | |
| parent | ff5ce21e1b959206f257967d6de2efa6f4e3d188 (diff) | |
| download | qemu-3d01141144583bd12b5d7c76326328e509a677ec.zip qemu-3d01141144583bd12b5d7c76326328e509a677ec.tar.gz qemu-3d01141144583bd12b5d7c76326328e509a677ec.tar.bz2 | |
tpm-emulator: add a FIXME comment about blocking cancel
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/tpm/tpm_emulator.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/hw/tpm/tpm_emulator.c b/hw/tpm/tpm_emulator.c index 94e6660..24cb611 100644 --- a/hw/tpm/tpm_emulator.c +++ b/hw/tpm/tpm_emulator.c @@ -338,6 +338,7 @@ static void tpm_emulator_cancel_cmd(TPMBackend *tb) return; } + /* FIXME: make the function non-blocking, or it may block a VCPU */ if (tpm_emulator_ctrlcmd(tpm_emu, CMD_CANCEL_TPM_CMD, &res, 0, sizeof(res)) < 0) { error_report("tpm-emulator: Could not cancel command: %s", |