diff options
| author | Markus Armbruster <armbru@redhat.com> | 2018-10-17 10:26:40 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2018-10-19 14:51:34 +0200 |
| commit | fff4c9c32595e71bca3d1a89beb0781a5be2201b (patch) | |
| tree | 09a094aef1a8995b90b0c91b92db8c994746fac6 /hw/xen | |
| parent | a22528b918c7d29795129b5a64c4cb44bb57a44d (diff) | |
| download | qemu-fff4c9c32595e71bca3d1a89beb0781a5be2201b.zip qemu-fff4c9c32595e71bca3d1a89beb0781a5be2201b.tar.gz qemu-fff4c9c32595e71bca3d1a89beb0781a5be2201b.tar.bz2 | |
xen/pt: Fix incomplete conversion to realize()
The conversion of "xen-pci-passthrough" to realize() (commit
5a11d0f7549, v2.6.0) neglected to convert the xen_pt_config_init()
error path. If xen_pt_config_init() fails, xen_pt_realize() reports
the error, then returns success without completing its job. I don't
know the exact impact, but it can't be good.
Belatedly convert the error path.
Fixes: 5a11d0f7549e24a10e178a9dc8ff5e698031d9a6
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Anthony Perard <anthony.perard@citrix.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Message-Id: <20181017082702.5581-17-armbru@redhat.com>
Diffstat (limited to 'hw/xen')
| -rw-r--r-- | hw/xen/xen_pt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index e5a6eff..f1f3a37 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -830,7 +830,7 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) xen_pt_config_init(s, &err); if (err) { error_append_hint(&err, "PCI Config space initialisation failed"); - error_report_err(err); + error_propagate(errp, err); rc = -1; goto err_out; } |