diff options
| author | Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> | 2023-01-27 06:08:14 +0100 |
|---|---|---|
| committer | Anthony PERARD <anthony.perard@citrix.com> | 2023-03-06 11:27:37 +0000 |
| commit | 3856734d80fbf46683e4080117ed961f5ab1300b (patch) | |
| tree | 2c2c189ede0166da2fb40cec5ca47829d6767e44 /hw/xen | |
| parent | 4f67543bb8c5b031c2ad3785c1a2f3c255d72b25 (diff) | |
| download | qemu-3856734d80fbf46683e4080117ed961f5ab1300b.zip qemu-3856734d80fbf46683e4080117ed961f5ab1300b.tar.gz qemu-3856734d80fbf46683e4080117ed961f5ab1300b.tar.bz2 | |
hw/xen/xen_pt: fix uninitialized variable
xen_pt_config_reg_init() reads only that many bytes as the size of the
register that is being initialized. It uses
xen_host_pci_get_{byte,word,long} and casts its last argument to
expected pointer type. This means for smaller registers higher bits of
'val' are not initialized. Then, the function fails if any of those
higher bits are set.
Fix this by initializing 'val' with zero.
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Message-Id: <20230127050815.4155276-1-marmarek@invisiblethingslab.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Diffstat (limited to 'hw/xen')
| -rw-r--r-- | hw/xen/xen_pt_config_init.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c index cde898b..8b9b554 100644 --- a/hw/xen/xen_pt_config_init.c +++ b/hw/xen/xen_pt_config_init.c @@ -1924,7 +1924,7 @@ static void xen_pt_config_reg_init(XenPCIPassthroughState *s, if (reg->init) { uint32_t host_mask, size_mask; unsigned int offset; - uint32_t val; + uint32_t val = 0; /* initialize emulate register */ rc = reg->init(s, reg_entry->reg, |