diff options
| author | Pankaj Gupta <pagupta@redhat.com> | 2019-07-12 13:05:53 +0530 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2019-07-12 10:56:27 -0400 |
| commit | 7b8a8474249eec97cd6a82f78b91183626fda65b (patch) | |
| tree | 675b6afd6580b7b50454bff170a296ca234009ba /hw/virtio | |
| parent | f37f47126236c8dc710d97da8ca9d43c38bef4ec (diff) | |
| download | qemu-7b8a8474249eec97cd6a82f78b91183626fda65b.zip qemu-7b8a8474249eec97cd6a82f78b91183626fda65b.tar.gz qemu-7b8a8474249eec97cd6a82f78b91183626fda65b.tar.bz2 | |
virtio pmem: remove memdev null check
Coverity reports that when we're assigning vi->size we handle the
"pmem->memdev is NULL" case; but we then pass it into
object_get_canonical_path(), which unconditionally dereferences it
and will crash if it is NULL. If this pointer can be NULL then we
need to do something else here.
We are removing 'pmem->memdev' null check here as memdev will never
be null in this function.
Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
Message-Id: <20190712073554.21918-3-pagupta@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Diffstat (limited to 'hw/virtio')
| -rw-r--r-- | hw/virtio/virtio-pmem.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/virtio/virtio-pmem.c b/hw/virtio/virtio-pmem.c index adbfb60..17c196d 100644 --- a/hw/virtio/virtio-pmem.c +++ b/hw/virtio/virtio-pmem.c @@ -134,8 +134,8 @@ static void virtio_pmem_fill_device_info(const VirtIOPMEM *pmem, VirtioPMEMDeviceInfo *vi) { vi->memaddr = pmem->start; - vi->size = pmem->memdev ? memory_region_size(&pmem->memdev->mr) : 0; - vi->memdev = object_get_canonical_path(OBJECT(pmem->memdev)); + vi->size = memory_region_size(&pmem->memdev->mr); + vi->memdev = object_get_canonical_path(OBJECT(pmem->memdev)); } static MemoryRegion *virtio_pmem_get_memory_region(VirtIOPMEM *pmem, |