diff options
| author | Andrey Gruzdev <andrey.gruzdev@virtuozzo.com> | 2021-04-01 12:22:24 +0300 |
|---|---|---|
| committer | Dr. David Alan Gilbert <dgilbert@redhat.com> | 2021-04-06 18:56:01 +0100 |
| commit | 1a8e44a89f1976e06300393337f78d561f95b339 (patch) | |
| tree | 3d0fc9a3ed4453a02bc02b6c3c8aa867b1835b2d /hw/virtio/virtio-balloon.c | |
| parent | ecb23efea0899be6723f4ea9636de5cf7de90cfe (diff) | |
| download | qemu-1a8e44a89f1976e06300393337f78d561f95b339.zip qemu-1a8e44a89f1976e06300393337f78d561f95b339.tar.gz qemu-1a8e44a89f1976e06300393337f78d561f95b339.tar.bz2 | |
migration: Inhibit virtio-balloon for the duration of background snapshot
The same thing as for incoming postcopy - we cannot deal with concurrent
RAM discards when using background snapshot feature in outgoing migration.
Fixes: 8518278a6af589ccc401f06e35f171b1e6fae800 (migration: implementation
of background snapshot thread)
Signed-off-by: Andrey Gruzdev <andrey.gruzdev@virtuozzo.com>
Reported-by: David Hildenbrand <david@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20210401092226.102804-3-andrey.gruzdev@virtuozzo.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Diffstat (limited to 'hw/virtio/virtio-balloon.c')
| -rw-r--r-- | hw/virtio/virtio-balloon.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index e770955..d120bf8 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virtio/virtio-balloon.c @@ -66,8 +66,12 @@ static bool virtio_balloon_pbp_matches(PartiallyBalloonedPage *pbp, static bool virtio_balloon_inhibited(void) { - /* Postcopy cannot deal with concurrent discards, so it's special. */ - return ram_block_discard_is_disabled() || migration_in_incoming_postcopy(); + /* + * Postcopy cannot deal with concurrent discards, + * so it's special, as well as background snapshots. + */ + return ram_block_discard_is_disabled() || migration_in_incoming_postcopy() || + migration_in_bg_snapshot(); } static void balloon_inflate_page(VirtIOBalloon *balloon, |