diff options
| author | Amit Shah <amit.shah@redhat.com> | 2010-04-27 18:04:09 +0530 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2010-04-28 08:58:22 -0500 |
| commit | 1e4476aa03b70e78b0dbc21cebd6e9f9c6835067 (patch) | |
| tree | 368c24eb66236e911fb5d3d38289c2f63d569cc9 /hw/virtio-serial.h | |
| parent | e85ba9b2dce43d706e21135fc1bf21a30601c2cf (diff) | |
| download | qemu-1e4476aa03b70e78b0dbc21cebd6e9f9c6835067.zip qemu-1e4476aa03b70e78b0dbc21cebd6e9f9c6835067.tar.gz qemu-1e4476aa03b70e78b0dbc21cebd6e9f9c6835067.tar.bz2 | |
virtio-serial: Apps should consume all data that guest sends out / Fix virtio api abuse
We cannot indicate to the guest how much data was consumed by an app for
out_bufs. So we just have to assume the apps will consume all the data
that are handed over to them.
Fix the virtio api abuse in control_out() and handle_output().
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/virtio-serial.h')
| -rw-r--r-- | hw/virtio-serial.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/hw/virtio-serial.h b/hw/virtio-serial.h index f023873..62d76a2 100644 --- a/hw/virtio-serial.h +++ b/hw/virtio-serial.h @@ -136,10 +136,10 @@ struct VirtIOSerialPortInfo { /* * Guest wrote some data to the port. This data is handed over to - * the app via this callback. The app should return the number of - * bytes it successfully consumed. + * the app via this callback. The app is supposed to consume all + * the data that is presented to it. */ - size_t (*have_data)(VirtIOSerialPort *port, const uint8_t *buf, size_t len); + void (*have_data)(VirtIOSerialPort *port, const uint8_t *buf, size_t len); }; /* Interface to the virtio-serial bus */ |