diff options
| author | Markus Armbruster <armbru@redhat.com> | 2010-07-06 14:37:44 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2010-07-13 17:48:17 +0200 |
| commit | 98f28ad7a7d26e5e77c5cb37b262d76d6ccd963d (patch) | |
| tree | a17198bf6887562708d62a0cf13b17777645cd67 /hw/virtio-blk.c | |
| parent | d75d25e34e4b4eb6a18122b5fa3baac70cea0f2b (diff) | |
| download | qemu-98f28ad7a7d26e5e77c5cb37b262d76d6ccd963d.zip qemu-98f28ad7a7d26e5e77c5cb37b262d76d6ccd963d.tar.gz qemu-98f28ad7a7d26e5e77c5cb37b262d76d6ccd963d.tar.bz2 | |
ide scsi virtio-blk: Reject empty drives unless media is removable
Disks without media make no sense. For SCSI, a Linux guest kernel
complains during boot. I didn't try other combinations.
scsi-generic doesn't need the additional check, because it already
requires bdrv_is_sg(), which fails without media.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'hw/virtio-blk.c')
| -rw-r--r-- | hw/virtio-blk.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 99e9dd2..f50069d 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -495,6 +495,10 @@ VirtIODevice *virtio_blk_init(DeviceState *dev, BlockConf *conf) error_report("virtio-blk-pci: drive property not set"); return NULL; } + if (!bdrv_is_inserted(conf->bs)) { + error_report("Device needs media, but drive is empty"); + return NULL; + } s = (VirtIOBlock *)virtio_common_init("virtio-blk", VIRTIO_ID_BLOCK, sizeof(struct virtio_blk_config), |