diff options
author | Markus Armbruster <armbru@redhat.com> | 2015-11-10 12:11:08 -0700 |
---|---|---|
committer | Alex Williamson <alex.williamson@redhat.com> | 2015-11-10 12:11:08 -0700 |
commit | bdd81addf4033ce26e6cd180b060f63095f3ded9 (patch) | |
tree | 3f5637ba3c46fe0a198d1d52c42221f71237922e /hw/vfio/pci.c | |
parent | 0282abf078c3353a178ab77a115828ce333181dd (diff) | |
download | qemu-bdd81addf4033ce26e6cd180b060f63095f3ded9.zip qemu-bdd81addf4033ce26e6cd180b060f63095f3ded9.tar.gz qemu-bdd81addf4033ce26e6cd180b060f63095f3ded9.tar.bz2 |
vfio: Use g_new() & friends where that makes obvious sense
g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
for two reasons. One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.
This commit only touches allocations with size arguments of the form
sizeof(T). Same Coccinelle semantic patch as in commit b45c03f.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'hw/vfio/pci.c')
-rw-r--r-- | hw/vfio/pci.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 035007f..1fb868c 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -587,7 +587,7 @@ static void vfio_msix_enable(VFIOPCIDevice *vdev) { vfio_disable_interrupts(vdev); - vdev->msi_vectors = g_malloc0(vdev->msix->entries * sizeof(VFIOMSIVector)); + vdev->msi_vectors = g_new0(VFIOMSIVector, vdev->msix->entries); vdev->interrupt = VFIO_INT_MSIX; @@ -623,7 +623,7 @@ static void vfio_msi_enable(VFIOPCIDevice *vdev) vdev->nr_vectors = msi_nr_vectors_allocated(&vdev->pdev); retry: - vdev->msi_vectors = g_malloc0(vdev->nr_vectors * sizeof(VFIOMSIVector)); + vdev->msi_vectors = g_new0(VFIOMSIVector, vdev->nr_vectors); for (i = 0; i < vdev->nr_vectors; i++) { VFIOMSIVector *vector = &vdev->msi_vectors[i]; |