aboutsummaryrefslogtreecommitdiff
path: root/hw/usb
diff options
context:
space:
mode:
authorQiang Liu <cyruscyliu@gmail.com>2022-09-04 20:59:26 +0800
committerGerd Hoffmann <kraxel@redhat.com>2022-09-27 07:32:30 +0200
commit145cdaba0f7ea721080e1289dc7a31bb2066406f (patch)
treed83e1d2107d699b1227d88179a9e68e798d1c2af /hw/usb
parent12b69878fc7b4b92b1bbd3959f2c3d4c717881fb (diff)
downloadqemu-145cdaba0f7ea721080e1289dc7a31bb2066406f.zip
qemu-145cdaba0f7ea721080e1289dc7a31bb2066406f.tar.gz
qemu-145cdaba0f7ea721080e1289dc7a31bb2066406f.tar.bz2
hcd-xhci: drop operation with secondary stream arrays enabled
The abort() in xhci_find_stream() can be triggered via enabling the secondary stream arrays by setting linear stream array (LSA) bit (in endpoint context) to 0. We may show warnings and drop this operation. Fixes: 024426acc0a2 ("usb-xhci: usb3 streams") Reported-by: Qiang Liu <cyruscyliu@gmail.com> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1192 Signed-off-by: Qiang Liu <cyruscyliu@gmail.com> Message-Id: <20220904125926.2141607-1-cyruscyliu@gmail.com> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'hw/usb')
-rw-r--r--hw/usb/hcd-xhci.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index acd60b1..8299f35 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -1020,7 +1020,9 @@ static XHCIStreamContext *xhci_find_stream(XHCIEPContext *epctx,
}
sctx = epctx->pstreams + streamid;
} else {
- FIXME("secondary streams not implemented yet");
+ fprintf(stderr, "xhci: FIXME: secondary streams not implemented yet");
+ *cc_error = CC_INVALID_STREAM_TYPE_ERROR;
+ return NULL;
}
if (sctx->sct == -1) {