diff options
| author | Anton Nefedov <anton.nefedov@virtuozzo.com> | 2017-07-06 15:08:52 +0300 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2017-07-14 11:04:33 +0200 |
| commit | 3065070153ef4235659d821c0d6fa28fd0630c57 (patch) | |
| tree | fa9b9f1378874f727da8faa466946b6ca5d38f23 /hw/usb/dev-serial.c | |
| parent | 7c44a2a9d178118193febd71cfc6943dd21bdde9 (diff) | |
| download | qemu-3065070153ef4235659d821c0d6fa28fd0630c57.zip qemu-3065070153ef4235659d821c0d6fa28fd0630c57.tar.gz qemu-3065070153ef4235659d821c0d6fa28fd0630c57.tar.bz2 | |
char: avoid chardevice direct access
frontends should avoid accessing CharDriver struct where possible
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <1499342940-56739-6-git-send-email-anton.nefedov@virtuozzo.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/usb/dev-serial.c')
| -rw-r--r-- | hw/usb/dev-serial.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c index dc145a6..94b5c34 100644 --- a/hw/usb/dev-serial.c +++ b/hw/usb/dev-serial.c @@ -484,13 +484,12 @@ static void usb_serial_realize(USBDevice *dev, Error **errp) { USBSerialState *s = USB_SERIAL_DEV(dev); Error *local_err = NULL; - Chardev *chr = qemu_chr_fe_get_driver(&s->cs); usb_desc_create_serial(dev); usb_desc_init(dev); dev->auto_attach = 0; - if (!chr) { + if (!qemu_chr_fe_backend_connected(&s->cs)) { error_setg(errp, "Property chardev is required"); return; } @@ -505,7 +504,7 @@ static void usb_serial_realize(USBDevice *dev, Error **errp) usb_serial_event, NULL, s, NULL, true); usb_serial_handle_reset(dev); - if (chr->be_open && !dev->attached) { + if (qemu_chr_fe_backend_open(&s->cs) && !dev->attached) { usb_device_attach(dev, &error_abort); } } |