aboutsummaryrefslogtreecommitdiff
path: root/hw/tpm
diff options
context:
space:
mode:
authorStefan Berger <stefanb@linux.ibm.com>2023-07-13 13:19:55 -0400
committerStefan Berger <stefanb@linux.ibm.com>2023-07-14 11:31:54 -0400
commit4c46fe2ed492f35f411632c8b5a8442f322bc3f0 (patch)
treea504e8573e4a447e92565e51710852c5ed10a694 /hw/tpm
parent3dd9e54703e6ae4f9ab3767f5cecc99edf066668 (diff)
downloadqemu-4c46fe2ed492f35f411632c8b5a8442f322bc3f0.zip
qemu-4c46fe2ed492f35f411632c8b5a8442f322bc3f0.tar.gz
qemu-4c46fe2ed492f35f411632c8b5a8442f322bc3f0.tar.bz2
hw/tpm: TIS on sysbus: Remove unsupport ppi command line option
The ppi command line option for the TIS device on sysbus never worked and caused an immediate segfault. Remove support for it since it also needs support in the firmware and needs testing inside the VM. Reproducer with the ppi=on option passed: qemu-system-aarch64 \ -machine virt,gic-version=3 \ -m 4G \ -nographic -no-acpi \ -chardev socket,id=chrtpm,path=/tmp/mytpm1/swtpm-sock \ -tpmdev emulator,id=tpm0,chardev=chrtpm \ -device tpm-tis-device,tpmdev=tpm0,ppi=on [...] Segmentation fault (core dumped) Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> Reviewed-by: Eric Auger <eric.auger@redhat.com> Message-id: 20230713171955.149236-1-stefanb@linux.ibm.com
Diffstat (limited to 'hw/tpm')
-rw-r--r--hw/tpm/tpm_tis_sysbus.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c
index 45e63ef..6724b3d 100644
--- a/hw/tpm/tpm_tis_sysbus.c
+++ b/hw/tpm/tpm_tis_sysbus.c
@@ -93,7 +93,6 @@ static void tpm_tis_sysbus_reset(DeviceState *dev)
static Property tpm_tis_sysbus_properties[] = {
DEFINE_PROP_UINT32("irq", TPMStateSysBus, state.irq_num, TPM_TIS_IRQ),
DEFINE_PROP_TPMBE("tpmdev", TPMStateSysBus, state.be_driver),
- DEFINE_PROP_BOOL("ppi", TPMStateSysBus, state.ppi_enabled, false),
DEFINE_PROP_END_OF_LIST(),
};