aboutsummaryrefslogtreecommitdiff
path: root/hw/timer
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2021-03-30 14:05:34 +0100
committerPeter Maydell <peter.maydell@linaro.org>2021-03-30 14:05:34 +0100
commitb9e3f1579a4b06fc63dfa8cdb68df1c58eeb0cf1 (patch)
tree540613885eee8dd597f505c5c2a918e5e7165c64 /hw/timer
parentf7fb73b8cdd3f77e26f9fcff8cf24ff1b58d200f (diff)
downloadqemu-b9e3f1579a4b06fc63dfa8cdb68df1c58eeb0cf1.zip
qemu-b9e3f1579a4b06fc63dfa8cdb68df1c58eeb0cf1.tar.gz
qemu-b9e3f1579a4b06fc63dfa8cdb68df1c58eeb0cf1.tar.bz2
hw/timer/renesas_tmr: Add default-case asserts in read_tcnt()
In commit 81b3ddaf8772ec we fixed a use of uninitialized data in read_tcnt(). However this change wasn't enough to placate Coverity, which is not smart enough to see that if we read a 2 bit field and then handle cases 0, 1, 2 and 3 then there cannot be a flow of execution through the switch default. Add explicit default cases which assert that they can't be reached, which should help silence Coverity. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Message-id: 20210319162458.13760-1-peter.maydell@linaro.org
Diffstat (limited to 'hw/timer')
-rw-r--r--hw/timer/renesas_tmr.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/hw/timer/renesas_tmr.c b/hw/timer/renesas_tmr.c
index eed3991..d96002e 100644
--- a/hw/timer/renesas_tmr.c
+++ b/hw/timer/renesas_tmr.c
@@ -146,6 +146,8 @@ static uint16_t read_tcnt(RTMRState *tmr, unsigned size, int ch)
case CSS_CASCADING:
tcnt[1] = tmr->tcnt[1];
break;
+ default:
+ g_assert_not_reached();
}
switch (FIELD_EX8(tmr->tccr[0], TCCR, CSS)) {
case CSS_INTERNAL:
@@ -159,6 +161,8 @@ static uint16_t read_tcnt(RTMRState *tmr, unsigned size, int ch)
case CSS_EXTERNAL: /* QEMU doesn't implement this */
tcnt[0] = tmr->tcnt[0];
break;
+ default:
+ g_assert_not_reached();
}
} else {
tcnt[0] = tmr->tcnt[0];