aboutsummaryrefslogtreecommitdiff
path: root/hw/sh4
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@linaro.org>2023-10-19 12:04:09 +0200
committerPhilippe Mathieu-Daudé <philmd@linaro.org>2024-02-15 16:58:46 +0100
commit3c5f86a22686ef475a8259c0d8ee714f61c770c9 (patch)
tree41a32e0224fff84c819f730eeb332145efedd84a /hw/sh4
parentfc432ba0f58343c8912b80e9056315bb9bd8df92 (diff)
downloadqemu-3c5f86a22686ef475a8259c0d8ee714f61c770c9.zip
qemu-3c5f86a22686ef475a8259c0d8ee714f61c770c9.tar.gz
qemu-3c5f86a22686ef475a8259c0d8ee714f61c770c9.tar.bz2
hw/sh4/r2d: Realize IDE controller before accessing it
We should not wire IRQs on unrealized device. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-Id: <20240213130341.1793-8-philmd@linaro.org>
Diffstat (limited to 'hw/sh4')
-rw-r--r--hw/sh4/r2d.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c
index e9f316a..c73e8f4 100644
--- a/hw/sh4/r2d.c
+++ b/hw/sh4/r2d.c
@@ -285,9 +285,9 @@ static void r2d_init(MachineState *machine)
dinfo = drive_get(IF_IDE, 0, 0);
dev = qdev_new("mmio-ide");
busdev = SYS_BUS_DEVICE(dev);
- sysbus_connect_irq(busdev, 0, irq[CF_IDE]);
qdev_prop_set_uint32(dev, "shift", 1);
sysbus_realize_and_unref(busdev, &error_fatal);
+ sysbus_connect_irq(busdev, 0, irq[CF_IDE]);
sysbus_mmio_map(busdev, 0, 0x14001000);
sysbus_mmio_map(busdev, 1, 0x1400080c);
mmio_ide_init_drives(dev, dinfo, NULL);