diff options
author | Philippe Mathieu-Daudé <f4bug@amsat.org> | 2020-08-22 20:09:50 +0200 |
---|---|---|
committer | Laurent Vivier <laurent@vivier.eu> | 2020-09-11 21:25:59 +0200 |
commit | b42581f5bb40489cb172829e9ab0d6d6dfa37026 (patch) | |
tree | 53386cbc9808337c4bcc4d902f16f86942254271 /hw/sd | |
parent | 67263b33af9506d78558b1edfa5a9bf976dc7b3d (diff) | |
download | qemu-b42581f5bb40489cb172829e9ab0d6d6dfa37026.zip qemu-b42581f5bb40489cb172829e9ab0d6d6dfa37026.tar.gz qemu-b42581f5bb40489cb172829e9ab0d6d6dfa37026.tar.bz2 |
util/hexdump: Reorder qemu_hexdump() arguments
qemu_hexdump()'s pointer to the buffer and length of the
buffer are closely related arguments but are widely separated
in the argument list order (also, the format of <stdio.h>
function prototypes is usually to have the FILE* argument
coming first).
Reorder the arguments as "fp, prefix, buf, size" which is
more logical.
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Message-Id: <20200822180950.1343963-3-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'hw/sd')
-rw-r--r-- | hw/sd/sd.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -1785,7 +1785,7 @@ send_response: } #ifdef DEBUG_SD - qemu_hexdump(response, stderr, "Response", rsplen); + qemu_hexdump(stderr, "Response", response, rsplen); #endif return rsplen; |