aboutsummaryrefslogtreecommitdiff
path: root/hw/sd/sdhci.c
diff options
context:
space:
mode:
authorJean-Philippe Brucker <jean-philippe@linaro.org>2021-06-14 16:34:05 +0100
committerPeter Maydell <peter.maydell@linaro.org>2021-06-15 16:18:48 +0100
commit96a664d05c238ea1b64af2394b58e956fe0afe26 (patch)
treeb82a4d35c66d3c97b8b1b62b422d6c60f711c611 /hw/sd/sdhci.c
parent1ea06abceec61b6f3ab33dadb0510b6e09fb61e2 (diff)
downloadqemu-96a664d05c238ea1b64af2394b58e956fe0afe26.zip
qemu-96a664d05c238ea1b64af2394b58e956fe0afe26.tar.gz
qemu-96a664d05c238ea1b64af2394b58e956fe0afe26.tar.bz2
hw/intc/arm_gicv3_cpuif: Tolerate spurious EOIR writes
Commit 382c7160d1cd ("hw/intc/arm_gicv3_cpuif: Fix EOIR write access check logic") added an assert_not_reached() if the guest writes the EOIR register while no interrupt is active. It turns out some software does this: EDK2, in GicV3ExitBootServicesEvent(), unconditionally write EOIR for all interrupts that it manages. This now causes QEMU to abort when running UEFI on a VM with GICv3. Although it is UNPREDICTABLE behavior and EDK2 does need fixing, the punishment seems a little harsh, especially since icc_eoir_write() already tolerates writes of nonexistent interrupt numbers. Display a guest error and tolerate spurious EOIR writes. Fixes: 382c7160d1cd ("hw/intc/arm_gicv3_cpuif: Fix EOIR write access check logic") Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Tested-by: Alex Bennée <alex.bennee@linaro.org> Message-id: 20210604130352.1887560-1-jean-philippe@linaro.org Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'hw/sd/sdhci.c')
0 files changed, 0 insertions, 0 deletions