diff options
| author | Li Qiang <liqiang6-s@360.cn> | 2016-09-12 18:14:11 +0530 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2016-09-14 12:25:13 +0200 |
| commit | 670e56d3ed2918b3861d9216f2c0540d9e9ae0d5 (patch) | |
| tree | 9c2e1a74b181ee1222e66ef887133d853e3bb19c /hw/scsi/mptsas.c | |
| parent | 2a2d69f490c1b1dc6b6d2aef385ee7b654497a77 (diff) | |
| download | qemu-670e56d3ed2918b3861d9216f2c0540d9e9ae0d5.zip qemu-670e56d3ed2918b3861d9216f2c0540d9e9ae0d5.tar.gz qemu-670e56d3ed2918b3861d9216f2c0540d9e9ae0d5.tar.bz2 | |
scsi: mptsas: use g_new0 to allocate MPTSASRequest object
When processing IO request in mptsas, it uses g_new to allocate
a 'req' object. If an error occurs before 'req->sreq' is
allocated, It could lead to an OOB write in mptsas_free_request
function. Use g_new0 to avoid it.
Reported-by: Li Qiang <liqiang6-s@360.cn>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Message-Id: <1473684251-17476-1-git-send-email-ppandit@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/scsi/mptsas.c')
| -rw-r--r-- | hw/scsi/mptsas.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c index 0e0a22f..eaae1bb 100644 --- a/hw/scsi/mptsas.c +++ b/hw/scsi/mptsas.c @@ -304,7 +304,7 @@ static int mptsas_process_scsi_io_request(MPTSASState *s, goto bad; } - req = g_new(MPTSASRequest, 1); + req = g_new0(MPTSASRequest, 1); QTAILQ_INSERT_TAIL(&s->pending, req, next); req->scsi_io = *scsi_io; req->dev = s; |