diff options
| author | David Gibson <david@gibson.dropbear.id.au> | 2017-06-06 17:05:53 +1000 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2017-06-08 14:38:26 +1000 |
| commit | 7b7258f810d2bd40e2fb99c469c5db318d6c3d92 (patch) | |
| tree | 229e5bb5c345c0d62b2a0b0a44a19a8e338d0ebc /hw/ppc/trace-events | |
| parent | 454b580ae9ae3e7722f1cd5f6da7bb479f86bbd8 (diff) | |
| download | qemu-7b7258f810d2bd40e2fb99c469c5db318d6c3d92.zip qemu-7b7258f810d2bd40e2fb99c469c5db318d6c3d92.tar.gz qemu-7b7258f810d2bd40e2fb99c469c5db318d6c3d92.tar.bz2 | |
spapr: Clean up RTAS set-indicator
In theory the RTAS set-indicator call can be used for a number of
"indicators" defined by PAPR. In practice the only ones we're ever likely
to implement are those used for Dynamic Reconfiguration (i.e. hotplug).
Because of this, the current implementation determines the associated DRC
object, before dispatching based on the type of indicator.
However, this means we also need a check that we're dealing with a DR
related indicator at all, which duplicates some of the logic from the
switch further down.
Even though it means a bit of code duplication, things work out cleaner if
we delegate the DRC lookup to the individual indicator type functions -
and it also allows some further cleanups.
While we're there, remove references to "sensor", a copy/paste artefact
from the related, but distinct "get-sensor" call.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Acked-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Diffstat (limited to 'hw/ppc/trace-events')
| -rw-r--r-- | hw/ppc/trace-events | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/hw/ppc/trace-events b/hw/ppc/trace-events index 4979397..581fa85 100644 --- a/hw/ppc/trace-events +++ b/hw/ppc/trace-events @@ -60,8 +60,6 @@ spapr_ovec_parse_vector(int vector, int byte, uint16_t vec_len, uint8_t entry) " spapr_ovec_populate_dt(int byte, uint16_t vec_len, uint8_t entry) "encoding guest vector byte %3d / %3d: 0x%.2x" # hw/ppc/spapr_rtas.c -spapr_rtas_set_indicator_invalid(uint32_t index) "sensor index: 0x%"PRIx32 -spapr_rtas_set_indicator_not_supported(uint32_t index, uint32_t type) "sensor index: 0x%"PRIx32", type: %"PRIu32 spapr_rtas_get_sensor_state_not_supported(uint32_t index, uint32_t type) "sensor index: 0x%"PRIx32", type: %"PRIu32 spapr_rtas_get_sensor_state_invalid(uint32_t index) "sensor index: 0x%"PRIx32 spapr_rtas_ibm_configure_connector_invalid(uint32_t index) "DRC index: 0x%"PRIx32 |