diff options
| author | Gautam Agrawal <gautamnagrawal@gmail.com> | 2022-05-01 17:55:05 +0530 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2022-05-09 08:21:14 +0200 |
| commit | f9bcb2d68496a8fa620443edacb27cad1acc1492 (patch) | |
| tree | 5f4f8f52f36e0620718a2833e2903e59a50837ca /hw/ppc/spapr.c | |
| parent | 26f0ee7ddb9e95b3bde1d1b51d98334bebce0e1f (diff) | |
| download | qemu-f9bcb2d68496a8fa620443edacb27cad1acc1492.zip qemu-f9bcb2d68496a8fa620443edacb27cad1acc1492.tar.gz qemu-f9bcb2d68496a8fa620443edacb27cad1acc1492.tar.bz2 | |
Warn user if the vga flag is passed but no vga device is created
A global boolean variable "vga_interface_created"(declared in softmmu/globals.c)
has been used to track the creation of vga interface. If the vga flag is passed
in the command line "default_vga"(declared in softmmu/vl.c) variable is set to 0.
To warn user, the condition checks if vga_interface_created is false
and default_vga is equal to 0. If "-vga none" is passed, this patch will not warn the
user regarding the creation of VGA device.
The warning "A -vga option was passed but this
machine type does not use that option; no VGA device has been created"
is logged if vga flag is passed but no vga device is created.
This patch has been tested for x86_64, i386, sparc, sparc64 and arm boards.
Signed-off-by: Gautam Agrawal <gautamnagrawal@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/581
Message-Id: <20220501122505.29202-1-gautamnagrawal@gmail.com>
[thuth: Fix wrong warning with "-device" in some cases as reported by Paolo]
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'hw/ppc/spapr.c')
| -rw-r--r-- | hw/ppc/spapr.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index fe9937e..8bbae68 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1742,6 +1742,7 @@ static void spapr_rtc_create(SpaprMachineState *spapr) /* Returns whether we want to use VGA or not */ static bool spapr_vga_init(PCIBus *pci_bus, Error **errp) { + vga_interface_created = true; switch (vga_interface_type) { case VGA_NONE: return false; |