aboutsummaryrefslogtreecommitdiff
path: root/hw/pci/pcie.c
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2019-06-20 13:44:32 -0400
committerMichael S. Tsirkin <mst@redhat.com>2019-07-01 09:11:02 -0400
commit861dc73518a049887b709f031359713e5f6b284e (patch)
tree31a5a1c9db7a283768d847be9260ac7f4271a278 /hw/pci/pcie.c
parent7fec76a02267598a4e437ddfdaeaeb6de09b92f3 (diff)
downloadqemu-861dc73518a049887b709f031359713e5f6b284e.zip
qemu-861dc73518a049887b709f031359713e5f6b284e.tar.gz
qemu-861dc73518a049887b709f031359713e5f6b284e.tar.bz2
pcie: don't skip multi-mask events
If we are trying to set multiple bits at once, testing that just one of them is already set gives a false positive. As a result we won't interrupt guest if e.g. presence detection change and attention button press are both set. This happens with multi-function device removal. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'hw/pci/pcie.c')
-rw-r--r--hw/pci/pcie.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 88c30ff..b225270 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -383,7 +383,7 @@ static void pcie_cap_slot_event(PCIDevice *dev, PCIExpressHotPlugEvent event)
{
/* Minor optimization: if nothing changed - no event is needed. */
if (pci_word_test_and_set_mask(dev->config + dev->exp.exp_cap +
- PCI_EXP_SLTSTA, event)) {
+ PCI_EXP_SLTSTA, event) == event) {
return;
}
hotplug_event_notify(dev);