diff options
| author | Philippe Mathieu-Daudé <f4bug@amsat.org> | 2020-10-12 19:09:47 +0200 |
|---|---|---|
| committer | Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> | 2020-10-28 07:59:26 +0000 |
| commit | 0980307e705b5677d9b4158a0a0346abf5041f33 (patch) | |
| tree | 7e4b0b03478c289d02deb5c102d28abd5836a449 /hw/pci-host | |
| parent | a0376c0311bad493ef9e4cd9ed596463410c1965 (diff) | |
| download | qemu-0980307e705b5677d9b4158a0a0346abf5041f33.zip qemu-0980307e705b5677d9b4158a0a0346abf5041f33.tar.gz qemu-0980307e705b5677d9b4158a0a0346abf5041f33.tar.bz2 | |
hw/pci-host/sabre: Simplify code initializing variable once
We only need to zero-initialize 'val' once.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Message-Id: <20201012170950.3491912-4-f4bug@amsat.org>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Diffstat (limited to 'hw/pci-host')
| -rw-r--r-- | hw/pci-host/sabre.c | 12 |
1 files changed, 1 insertions, 11 deletions
diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index f678a3e..f41a0cc 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -195,32 +195,25 @@ static uint64_t sabre_config_read(void *opaque, hwaddr addr, unsigned size) { SabreState *s = opaque; - uint32_t val; + uint32_t val = 0; switch (addr) { case 0x30 ... 0x4f: /* DMA error registers */ - val = 0; /* XXX: not implemented yet */ break; case 0xc00 ... 0xc3f: /* PCI interrupt control */ if (addr & 4) { val = s->pci_irq_map[(addr & 0x3f) >> 3]; - } else { - val = 0; } break; case 0x1000 ... 0x107f: /* OBIO interrupt control */ if (addr & 4) { val = s->obio_irq_map[(addr & 0xff) >> 3]; - } else { - val = 0; } break; case 0x1080 ... 0x108f: /* PCI bus error */ if (addr & 4) { val = s->pci_err_irq_map[(addr & 0xf) >> 3]; - } else { - val = 0; } break; case 0x2000 ... 0x202f: /* PCI control */ @@ -229,8 +222,6 @@ static uint64_t sabre_config_read(void *opaque, case 0xf020 ... 0xf027: /* Reset control */ if (addr & 4) { val = s->reset_control; - } else { - val = 0; } break; case 0x5000 ... 0x51cf: /* PIO/DMA diagnostics */ @@ -239,7 +230,6 @@ static uint64_t sabre_config_read(void *opaque, case 0xf000 ... 0xf01f: /* FFB config, memory control */ /* we don't care */ default: - val = 0; break; } trace_sabre_config_read(addr, val); |