diff options
| author | Chen Qun <kuhn.chenqun@huawei.com> | 2020-08-27 19:03:07 +0800 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2020-09-01 11:59:59 +0200 |
| commit | b7ea580d0baad1227a341f2e1752e464319eb101 (patch) | |
| tree | a9ed6c78ff159df50f9c584497b1f84b0757cb1c /hw/net | |
| parent | 8b616beebcbb70444c2dbc07b210bd3798cf8462 (diff) | |
| download | qemu-b7ea580d0baad1227a341f2e1752e464319eb101.zip qemu-b7ea580d0baad1227a341f2e1752e464319eb101.tar.gz qemu-b7ea580d0baad1227a341f2e1752e464319eb101.tar.bz2 | |
hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check()
Clang static code analyzer show warning:
hw/net/virtio-net.c:2077:5: warning: Value stored to 'tcp_flag' is never read
tcp_flag &= VIRTIO_NET_TCP_FLAG;
^ ~~~~~~~~~~~~~~~~~~~
The 'VIRTIO_NET_TCP_FLAG' is '0x3F'. The last ‘tcp_flag’ assignment statement is
the same as that of the first two statements.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20200827110311.164316-7-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'hw/net')
| -rw-r--r-- | hw/net/virtio-net.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index a1fe9e9..cb0d270 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -2075,7 +2075,6 @@ static int virtio_net_rsc_tcp_ctrl_check(VirtioNetRscChain *chain, tcp_flag = htons(tcp->th_offset_flags); tcp_hdr = (tcp_flag & VIRTIO_NET_TCP_HDR_LENGTH) >> 10; tcp_flag &= VIRTIO_NET_TCP_FLAG; - tcp_flag = htons(tcp->th_offset_flags) & 0x3F; if (tcp_flag & TH_SYN) { chain->stat.tcp_syn++; return RSC_BYPASS; |