diff options
| author | Daniel P. Berrangé <berrange@redhat.com> | 2021-04-30 12:59:06 +0100 |
|---|---|---|
| committer | Daniel P. Berrangé <berrange@redhat.com> | 2021-07-14 14:15:52 +0100 |
| commit | 96916f36c4c86bd5f017cc58abca90b79693c878 (patch) | |
| tree | db3247db4c1359c4bffe94b90aebe378bf40fea0 /hw/net/rocker | |
| parent | 8bd0931f63008b1d50c8df75a611323a93c052bf (diff) | |
| download | qemu-96916f36c4c86bd5f017cc58abca90b79693c878.zip qemu-96916f36c4c86bd5f017cc58abca90b79693c878.tar.gz qemu-96916f36c4c86bd5f017cc58abca90b79693c878.tar.bz2 | |
net/rocker: use GDateTime for formatting timestamp in debug messages
The GDateTime APIs provided by GLib avoid portability pitfalls, such
as some platforms where 'struct timeval.tv_sec' field is still 'long'
instead of 'time_t'. When combined with automatic cleanup, GDateTime
often results in simpler code too.
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Diffstat (limited to 'hw/net/rocker')
| -rw-r--r-- | hw/net/rocker/rocker.h | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/hw/net/rocker/rocker.h b/hw/net/rocker/rocker.h index 941c932..412fa44 100644 --- a/hw/net/rocker/rocker.h +++ b/hw/net/rocker/rocker.h @@ -25,14 +25,9 @@ #if defined(DEBUG_ROCKER) # define DPRINTF(fmt, ...) \ do { \ - struct timeval tv; \ - char timestr[64]; \ - time_t now; \ - gettimeofday(&tv, NULL); \ - now = tv.tv_sec; \ - strftime(timestr, sizeof(timestr), "%T", localtime(&now)); \ - fprintf(stderr, "%s.%06ld ", timestr, tv.tv_usec); \ - fprintf(stderr, "ROCKER: " fmt, ## __VA_ARGS__); \ + g_autoptr(GDateTime) now = g_date_time_new_now_local(); \ + g_autofree char *nowstr = g_date_time_format(now, "%T.%f");\ + fprintf(stderr, "%s ROCKER: " fmt, nowstr, ## __VA_ARGS__);\ } while (0) #else static inline GCC_FMT_ATTR(1, 2) int DPRINTF(const char *fmt, ...) |