aboutsummaryrefslogtreecommitdiff
path: root/hw/misc/cbus.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2016-03-09 12:19:37 +0100
committerPaolo Bonzini <pbonzini@redhat.com>2016-03-22 22:20:16 +0100
commit0137fdc0941cfe214e91c5c1444f3fcf6a5548b8 (patch)
tree61f27c71cf084015b3c0f54de6321dba697e2b8c /hw/misc/cbus.c
parentdaf015ef5ab7b67f4676fcbe74c57b1709f6cb70 (diff)
downloadqemu-0137fdc0941cfe214e91c5c1444f3fcf6a5548b8.zip
qemu-0137fdc0941cfe214e91c5c1444f3fcf6a5548b8.tar.gz
qemu-0137fdc0941cfe214e91c5c1444f3fcf6a5548b8.tar.bz2
include/hw/hw.h: Don't include qemu-common.h
qemu-common.h should only be included by .c files. Its file comment explains why: "No header file should depend on qemu-common.h, as this would easily lead to circular header dependencies." hw/hw.h includes qemu-common.h, but its users generally need only hw_error() and qemu/module.h from it. Move the former to hw/hw.h, include the latter there, and drop the ill-advised include. hw/misc/cbus.c now misses hw_error(), so include hw/hw.h there. Signed-off-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/misc/cbus.c')
-rw-r--r--hw/misc/cbus.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/misc/cbus.c b/hw/misc/cbus.c
index fafe070..0c207e3 100644
--- a/hw/misc/cbus.c
+++ b/hw/misc/cbus.c
@@ -21,7 +21,7 @@
*/
#include "qemu/osdep.h"
-#include "qemu-common.h"
+#include "hw/hw.h"
#include "hw/irq.h"
#include "hw/devices.h"
#include "sysemu/sysemu.h"