diff options
| author | Philippe Mathieu-Daudé <f4bug@amsat.org> | 2020-09-01 12:40:40 +0200 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2020-09-09 15:22:50 +0200 |
| commit | 5e4b6bb1e8afb4cc2fcaaa6f3e57a6ec5184953f (patch) | |
| tree | efdf7d3e1c51ea9c50988746466d3b9ecaa99677 /hw/mips/fuloong2e.c | |
| parent | 9435a8b3dd35f1f926f1b9127e8a906217a5518a (diff) | |
| download | qemu-5e4b6bb1e8afb4cc2fcaaa6f3e57a6ec5184953f.zip qemu-5e4b6bb1e8afb4cc2fcaaa6f3e57a6ec5184953f.tar.gz qemu-5e4b6bb1e8afb4cc2fcaaa6f3e57a6ec5184953f.tar.bz2 | |
hw/mips/fuloong2e: Convert pointless error message to an assert()
Displaying "vt82c686b_init error" doesn't give any hint about why
this call failed. As this message targets developers and not users,
replace the pointless error message by a call to assert() which
will provide more useful information.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Huacai Chen <chenhc@lemote.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200901104043.91383-3-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'hw/mips/fuloong2e.c')
| -rw-r--r-- | hw/mips/fuloong2e.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c index 8ca31e5..f286099 100644 --- a/hw/mips/fuloong2e.c +++ b/hw/mips/fuloong2e.c @@ -240,10 +240,7 @@ static void vt82c686b_southbridge_init(PCIBus *pci_bus, int slot, qemu_irq intc, PCIDevice *dev; isa_bus = vt82c686b_isa_init(pci_bus, PCI_DEVFN(slot, 0)); - if (!isa_bus) { - fprintf(stderr, "vt82c686b_init error\n"); - exit(1); - } + assert(isa_bus); *p_isa_bus = isa_bus; /* Interrupt controller */ /* The 8259 -> IP5 */ |