diff options
| author | Philippe Mathieu-Daudé <philmd@linaro.org> | 2023-10-16 12:12:39 +0200 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2023-10-19 23:13:28 +0200 |
| commit | 40f8214fcde40bab3ef6d1ab0b2353c7f8bc62aa (patch) | |
| tree | 0a779fa08eccd417ca56f11b99741c4985179844 /hw/isa | |
| parent | 6c9dcd8760092e455f86f6afb05d87ea827da8f3 (diff) | |
| download | qemu-40f8214fcde40bab3ef6d1ab0b2353c7f8bc62aa.zip qemu-40f8214fcde40bab3ef6d1ab0b2353c7f8bc62aa.tar.gz qemu-40f8214fcde40bab3ef6d1ab0b2353c7f8bc62aa.tar.bz2 | |
hw/audio/pcspk: Inline pcspk_init()
pcspk_init() is a legacy init function, inline and remove it.
Since the device is realized using &error_fatal, use the same
error for setting the "pit" link.
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20231019073307.99608-1-philmd@linaro.org>
Diffstat (limited to 'hw/isa')
| -rw-r--r-- | hw/isa/i82378.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c index 63e0857..79ffbb5 100644 --- a/hw/isa/i82378.c +++ b/hw/isa/i82378.c @@ -67,6 +67,7 @@ static void i82378_realize(PCIDevice *pci, Error **errp) uint8_t *pci_conf; ISABus *isabus; ISADevice *pit; + ISADevice *pcspk; pci_conf = pci->config; pci_set_word(pci_conf + PCI_COMMAND, @@ -102,7 +103,9 @@ static void i82378_realize(PCIDevice *pci, Error **errp) pit = i8254_pit_init(isabus, 0x40, 0, NULL); /* speaker */ - pcspk_init(isa_new(TYPE_PC_SPEAKER), isabus, pit); + pcspk = isa_new(TYPE_PC_SPEAKER); + object_property_set_link(OBJECT(pcspk), "pit", OBJECT(pit), &error_fatal); + isa_realize_and_unref(pcspk, isabus, &error_fatal); /* 2 82C37 (dma) */ isa_create_simple(isabus, "i82374"); |