diff options
| author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:56 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:31:53 +0200 |
| commit | d5938f29fea29581725426f203a74da746ca03e7 (patch) | |
| tree | 0caa694b1084f73004a8eacced417b1ef3073fcc /hw/ide | |
| parent | b58c5c2dd29db0eae0bed800ac1a311e14007cec (diff) | |
| download | qemu-d5938f29fea29581725426f203a74da746ca03e7.zip qemu-d5938f29fea29581725426f203a74da746ca03e7.tar.gz qemu-d5938f29fea29581725426f203a74da746ca03e7.tar.bz2 | |
Clean up inclusion of sysemu/sysemu.h
In my "build everything" tree, changing sysemu/sysemu.h triggers a
recompile of some 5400 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h).
Almost a third of its inclusions are actually superfluous. Delete
them. Downgrade two more to qapi/qapi-types-run-state.h, and move one
from char/serial.h to char/serial.c.
hw/semihosting/config.c, monitor/monitor.c, qdev-monitor.c, and
stubs/semihost.c define variables declared in sysemu/sysemu.h without
including it. The compiler is cool with that, but include it anyway.
This doesn't reduce actual use much, as it's still included into
widely included headers. The next commit will tackle that.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190812052359.30071-27-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Diffstat (limited to 'hw/ide')
| -rw-r--r-- | hw/ide/cmd646.c | 1 | ||||
| -rw-r--r-- | hw/ide/ioport.c | 1 | ||||
| -rw-r--r-- | hw/ide/piix.c | 1 | ||||
| -rw-r--r-- | hw/ide/via.c | 1 |
4 files changed, 0 insertions, 4 deletions
diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index 3fbfc5e..f3ccd11 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -29,7 +29,6 @@ #include "migration/vmstate.h" #include "qemu/module.h" #include "hw/isa/isa.h" -#include "sysemu/sysemu.h" #include "sysemu/dma.h" #include "sysemu/reset.h" diff --git a/hw/ide/ioport.c b/hw/ide/ioport.c index e608561..ab1f4e5 100644 --- a/hw/ide/ioport.c +++ b/hw/ide/ioport.c @@ -27,7 +27,6 @@ #include "hw/isa/isa.h" #include "qemu/error-report.h" #include "qemu/timer.h" -#include "sysemu/sysemu.h" #include "sysemu/blockdev.h" #include "sysemu/dma.h" #include "hw/block/block.h" diff --git a/hw/ide/piix.c b/hw/ide/piix.c index bcfd119..fba6bc8 100644 --- a/hw/ide/piix.c +++ b/hw/ide/piix.c @@ -28,7 +28,6 @@ #include "migration/vmstate.h" #include "qemu/module.h" #include "sysemu/block-backend.h" -#include "sysemu/sysemu.h" #include "sysemu/blockdev.h" #include "sysemu/dma.h" #include "sysemu/reset.h" diff --git a/hw/ide/via.c b/hw/ide/via.c index 45f9293..7087dc6 100644 --- a/hw/ide/via.c +++ b/hw/ide/via.c @@ -28,7 +28,6 @@ #include "hw/pci/pci.h" #include "migration/vmstate.h" #include "qemu/module.h" -#include "sysemu/sysemu.h" #include "sysemu/dma.h" #include "sysemu/reset.h" |