diff options
author | Markus Armbruster <armbru@redhat.com> | 2016-01-14 16:09:38 +0100 |
---|---|---|
committer | Stefano Stabellini <stefano.stabellini@eu.citrix.com> | 2016-01-14 16:49:36 +0000 |
commit | dced4d2fcb3961358b12ec3a191dd04505f333af (patch) | |
tree | 85a02abd9ffb53d62da35dce15621f632fa1b3f9 /hw/i386/pc_q35.c | |
parent | ac0487e1d2ae811cd4d035741a109a4ecfb013f1 (diff) | |
download | qemu-dced4d2fcb3961358b12ec3a191dd04505f333af.zip qemu-dced4d2fcb3961358b12ec3a191dd04505f333af.tar.gz qemu-dced4d2fcb3961358b12ec3a191dd04505f333af.tar.bz2 |
xen-hvm: Clean up xen_hvm_init() error handling
xen_hvm_init() returns -1 without cleaning up on some errors (harmless
long as the caller exit()s on error), dies with hw_error() on others.
hw_error() isn't approprate here. Clean up to exit() on all errors.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Diffstat (limited to 'hw/i386/pc_q35.c')
-rw-r--r-- | hw/i386/pc_q35.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 412b3cd..abbcbf9 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -111,9 +111,8 @@ static void pc_q35_init(MachineState *machine) pcms->below_4g_mem_size = machine->ram_size; } - if (xen_enabled() && xen_hvm_init(pcms, &ram_memory) != 0) { - fprintf(stderr, "xen hardware virtual machine initialisation failed\n"); - exit(1); + if (xen_enabled()) { + xen_hvm_init(pcms, &ram_memory); } pc_cpus_init(pcms); |