diff options
author | Paolo Bonzini <pbonzini@redhat.com> | 2022-04-27 15:08:30 +0200 |
---|---|---|
committer | Paolo Bonzini <pbonzini@redhat.com> | 2022-05-12 12:29:44 +0200 |
commit | f0d43b1ecef04105e0d0f55658182510b4e0f58e (patch) | |
tree | 4111e660ac9f48f89b00e440332dcbc8891b088f /hw/i2c/smbus_ich9.c | |
parent | d6ee15adec5a2345e88c680cd15ed48796c89c14 (diff) | |
download | qemu-f0d43b1ecef04105e0d0f55658182510b4e0f58e.zip qemu-f0d43b1ecef04105e0d0f55658182510b4e0f58e.tar.gz qemu-f0d43b1ecef04105e0d0f55658182510b4e0f58e.tar.bz2 |
coroutine-lock: qemu_co_queue_restart_all is a coroutine-only qemu_co_enter_all
qemu_co_queue_restart_all is basically the same as qemu_co_enter_all
but without a QemuLockable argument. That's perfectly fine, but only as
long as the function is marked coroutine_fn. If used outside coroutine
context, qemu_co_queue_wait will attempt to take the lock and that
is just broken: if you are calling qemu_co_queue_restart_all outside
coroutine context, the lock is going to be a QemuMutex which cannot be
taken twice by the same thread.
The patch adds the marker to qemu_co_queue_restart_all and to its sole
non-coroutine_fn caller; it then reimplements the function in terms of
qemu_co_enter_all_impl, to remove duplicated code and to clarify that the
latter also works in coroutine context.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20220427130830.150180-4-pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/i2c/smbus_ich9.c')
0 files changed, 0 insertions, 0 deletions