aboutsummaryrefslogtreecommitdiff
path: root/hw/display
diff options
context:
space:
mode:
authorQiang Liu <cyruscyliu@gmail.com>2022-08-08 16:01:16 +0800
committerLaurent Vivier <laurent@vivier.eu>2022-08-08 11:40:06 +0200
commit9390da5ef29a5e0f98e5b482dceeeb287c452f17 (patch)
treec20428fb4b7805a1a50d3393a2a190b88357b31b /hw/display
parenta32086de4919b9affb2ab2d0112d400eaf89f607 (diff)
downloadqemu-9390da5ef29a5e0f98e5b482dceeeb287c452f17.zip
qemu-9390da5ef29a5e0f98e5b482dceeeb287c452f17.tar.gz
qemu-9390da5ef29a5e0f98e5b482dceeeb287c452f17.tar.bz2
xlnx_dp: drop unsupported AUXCommand in xlnx_dp_aux_set_command
In xlnx_dp_aux_set_command, when the command leads to the default branch, xlxn-dp will abort and then crash. This patch removes this abort and drops this operation. Fixes: 58ac482 ("introduce xlnx-dp") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/411 Reported-by: Qiang Liu <cyruscyliu@gmail.com> Tested-by: Qiang Liu <cyruscyliu@gmail.com> Suggested-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Qiang Liu <cyruscyliu@gmail.com> Reviewed-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Frederic Konrad <fkonrad@amd.com> Message-Id: <20220808080116.2184881-1-cyruscyliu@gmail.com> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'hw/display')
-rw-r--r--hw/display/xlnx_dp.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c
index a071c81..b0828d6 100644
--- a/hw/display/xlnx_dp.c
+++ b/hw/display/xlnx_dp.c
@@ -532,8 +532,8 @@ static void xlnx_dp_aux_set_command(XlnxDPState *s, uint32_t value)
qemu_log_mask(LOG_UNIMP, "xlnx_dp: Write i2c status not implemented\n");
break;
default:
- error_report("%s: invalid command: %u", __func__, cmd);
- abort();
+ qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid command: %u", __func__, cmd);
+ return;
}
s->core_registers[DP_INTERRUPT_SIGNAL_STATE] |= 0x04;