aboutsummaryrefslogtreecommitdiff
path: root/hw/display/omap_lcdc.c
diff options
context:
space:
mode:
authorIlya Maximets <i.maximets@ovn.org>2023-09-27 15:59:41 +0200
committerMichael S. Tsirkin <mst@redhat.com>2023-10-04 18:15:06 -0400
commitd501f97d9607eff1750549e0270c034102786d33 (patch)
tree857152e3d9d83326398912d6959ab48138abee25 /hw/display/omap_lcdc.c
parent850cd20b072cd330cb24aa1c92732b9722998d40 (diff)
downloadqemu-d501f97d9607eff1750549e0270c034102786d33.zip
qemu-d501f97d9607eff1750549e0270c034102786d33.tar.gz
qemu-d501f97d9607eff1750549e0270c034102786d33.tar.bz2
virtio: remove unnecessary thread fence while reading next descriptor
It was supposed to be a compiler barrier and it was a compiler barrier initially called 'wmb' when virtio core support was introduced. Later all the instances of 'wmb' were switched to smp_wmb to fix memory ordering issues on non-x86 platforms. However, this one doesn't need to be an actual barrier, as its only purpose was to ensure that the value is not read twice. And since commit aa570d6fb6bd ("virtio: combine the read of a descriptor") there is no need for a barrier at all, since we're no longer reading guest memory here, but accessing a local structure. Signed-off-by: Ilya Maximets <i.maximets@ovn.org> Message-Id: <20230927140016.2317404-2-i.maximets@ovn.org> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/display/omap_lcdc.c')
0 files changed, 0 insertions, 0 deletions