aboutsummaryrefslogtreecommitdiff
path: root/hw/char
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2018-04-20 15:52:37 +0100
committerPeter Maydell <peter.maydell@linaro.org>2018-04-26 13:57:00 +0100
commit47c4f85a0c27888e12af827471cfef87deb49821 (patch)
treea780f1f3df4a7f409bf197df4410d8a19ae86cae /hw/char
parent20b2323edf8d42fe024902ca7d847b9f71c98df1 (diff)
downloadqemu-47c4f85a0c27888e12af827471cfef87deb49821.zip
qemu-47c4f85a0c27888e12af827471cfef87deb49821.tar.gz
qemu-47c4f85a0c27888e12af827471cfef87deb49821.tar.bz2
hw/char/serial: Allow disconnected chardevs
Currently the serial.c realize code has an explicit check that it is not connected to a disconnected backend (ie one with a NULL chardev). This isn't what we want -- you should be able to create a serial device even if it isn't attached to anything. Remove the check. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Acked-by: Thomas Huth <thuth@redhat.com> Message-id: 20180420145249.32435-2-peter.maydell@linaro.org
Diffstat (limited to 'hw/char')
-rw-r--r--hw/char/serial.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/hw/char/serial.c b/hw/char/serial.c
index eb72191..2c080c9 100644
--- a/hw/char/serial.c
+++ b/hw/char/serial.c
@@ -923,11 +923,6 @@ static int serial_be_change(void *opaque)
void serial_realize_core(SerialState *s, Error **errp)
{
- if (!qemu_chr_fe_backend_connected(&s->chr)) {
- error_setg(errp, "Can't create serial device, empty char device");
- return;
- }
-
s->modem_status_poll = timer_new_ns(QEMU_CLOCK_VIRTUAL, (QEMUTimerCB *) serial_update_msl, s);
s->fifo_timeout_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, (QEMUTimerCB *) fifo_timeout_int, s);