diff options
| author | Markus Armbruster <armbru@redhat.com> | 2023-09-21 14:13:11 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2023-09-29 08:13:57 +0200 |
| commit | fb2575f95411644abe7f0606594035b63a5132ad (patch) | |
| tree | e9e0fe4dc77d0d3575436232a7ce4d8d35a20c82 /hw/block | |
| parent | d25b99c72b0178ce0e0c766b07011102dbbacf6a (diff) | |
| download | qemu-fb2575f95411644abe7f0606594035b63a5132ad.zip qemu-fb2575f95411644abe7f0606594035b63a5132ad.tar.gz qemu-fb2575f95411644abe7f0606594035b63a5132ad.tar.bz2 | |
block: Clean up local variable shadowing
Local variables shadowing other local variables or parameters make the
code needlessly hard to understand. Tracked down with -Wshadow=local.
Clean up: delete inner declarations when they are actually redundant,
else rename variables.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Acked-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20230921121312.1301864-7-armbru@redhat.com>
Diffstat (limited to 'hw/block')
| -rw-r--r-- | hw/block/xen-block.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index 3906b90..a07cd7e 100644 --- a/hw/block/xen-block.c +++ b/hw/block/xen-block.c @@ -369,7 +369,7 @@ static void xen_block_get_vdev(Object *obj, Visitor *v, const char *name, case XEN_BLOCK_VDEV_TYPE_XVD: case XEN_BLOCK_VDEV_TYPE_HD: case XEN_BLOCK_VDEV_TYPE_SD: { - char *name = disk_to_vbd_name(vdev->disk); + char *vbd_name = disk_to_vbd_name(vdev->disk); str = g_strdup_printf("%s%s%lu", (vdev->type == XEN_BLOCK_VDEV_TYPE_XVD) ? @@ -377,8 +377,8 @@ static void xen_block_get_vdev(Object *obj, Visitor *v, const char *name, (vdev->type == XEN_BLOCK_VDEV_TYPE_HD) ? "hd" : "sd", - name, vdev->partition); - g_free(name); + vbd_name, vdev->partition); + g_free(vbd_name); break; } default: |