aboutsummaryrefslogtreecommitdiff
path: root/hw/block
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@redhat.com>2019-05-18 20:57:02 +0200
committerPhilippe Mathieu-Daudé <philmd@redhat.com>2019-07-02 02:32:39 +0200
commit102f0f79a51cfc289f7ad19a10be654925faeff3 (patch)
tree15377140439d898e8cb6f6f58cf384d37b657645 /hw/block
parent64659053557a6a19bb00bb226e9b4d8f78cead7b (diff)
downloadqemu-102f0f79a51cfc289f7ad19a10be654925faeff3.zip
qemu-102f0f79a51cfc289f7ad19a10be654925faeff3.tar.gz
qemu-102f0f79a51cfc289f7ad19a10be654925faeff3.tar.bz2
hw/block/pflash_cfi02: Extract pflash_regions_count()
Extract the pflash_regions_count() function, the code will be easier to review. Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Message-Id: <20190627202719.17739-20-philmd@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'hw/block')
-rw-r--r--hw/block/pflash_cfi02.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index 1f096ec..a0d3bd6 100644
--- a/hw/block/pflash_cfi02.c
+++ b/hw/block/pflash_cfi02.c
@@ -157,6 +157,11 @@ static void pflash_register_memory(PFlashCFI02 *pfl, int rom_mode)
pfl->rom_mode = rom_mode;
}
+static size_t pflash_regions_count(PFlashCFI02 *pfl)
+{
+ return pfl->cfi_table[0x2c];
+}
+
static void pflash_timer (void *opaque)
{
PFlashCFI02 *pfl = opaque;
@@ -192,9 +197,8 @@ static uint64_t pflash_data_read(PFlashCFI02 *pfl, hwaddr offset,
static uint32_t pflash_sector_len(PFlashCFI02 *pfl, hwaddr offset)
{
assert(offset < pfl->chip_len);
- int nb_regions = pfl->cfi_table[0x2C];
hwaddr addr = 0;
- for (int i = 0; i < nb_regions; ++i) {
+ for (int i = 0; i < pflash_regions_count(pfl); ++i) {
uint64_t region_size = (uint64_t)pfl->nb_blocs[i] * pfl->sector_len[i];
if (addr <= offset && offset < addr + region_size) {
return pfl->sector_len[i];