diff options
| author | Li Qiang <liq3ea@gmail.com> | 2018-10-28 23:29:40 -0700 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2018-11-12 17:46:57 +0100 |
| commit | 20faf0f5f8aba33405a6206cd26f0d2b49ac174a (patch) | |
| tree | 995a7904cb927686fe068d092eeeb292ef2ac45e /hw/block | |
| parent | d52e1a0e967a532867149c2d95c2dd664ca22fe8 (diff) | |
| download | qemu-20faf0f5f8aba33405a6206cd26f0d2b49ac174a.zip qemu-20faf0f5f8aba33405a6206cd26f0d2b49ac174a.tar.gz qemu-20faf0f5f8aba33405a6206cd26f0d2b49ac174a.tar.bz2 | |
nvme: don't unref ctrl_mem when device unrealized
Currently, when hotplug/unhotplug nvme device, it will cause an
assert in object.c. Following is the backtrack:
ERROR:qom/object.c:981:object_unref: assertion failed: (obj->ref > 0)
Thread 2 "qemu-system-x86" received signal SIGABRT, Aborted.
[Switching to Thread 0x7fffcbd32700 (LWP 18844)]
0x00007fffdb9e4fff in raise () from /lib/x86_64-linux-gnu/libc.so.6
(gdb) bt
/lib/x86_64-linux-gnu/libglib-2.0.so.0
/lib/x86_64-linux-gnu/libglib-2.0.so.0
qom/object.c:981
/home/liqiang02/qemu-upstream/qemu/memory.c:1732
/home/liqiang02/qemu-upstream/qemu/memory.c:285
util/qemu-thread-posix.c:504
/lib/x86_64-linux-gnu/libpthread.so.0
This is caused by memory_region_unref in nvme_exit.
Remove it to make the PCIdevice refcount correct.
Signed-off-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'hw/block')
| -rw-r--r-- | hw/block/nvme.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/hw/block/nvme.c b/hw/block/nvme.c index fc7dacb..359a06d 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -1331,9 +1331,6 @@ static void nvme_exit(PCIDevice *pci_dev) g_free(n->namespaces); g_free(n->cq); g_free(n->sq); - if (n->cmbsz) { - memory_region_unref(&n->ctrl_mem); - } msix_uninit_exclusive_bar(pci_dev); } |