diff options
| author | Eugenio Pérez <eperezma@redhat.com> | 2019-10-25 10:35:22 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2019-10-25 07:46:22 -0400 |
| commit | 4a0117cf6e04d568a1963540bc0fa133b4d09b33 (patch) | |
| tree | 76a38183d13bc3eae7fe4cadd6ffe3a78e6f55e3 /hw/block/virtio-blk.c | |
| parent | f90cda636d4d18f691d8e9ff386e222570ff6552 (diff) | |
| download | qemu-4a0117cf6e04d568a1963540bc0fa133b4d09b33.zip qemu-4a0117cf6e04d568a1963540bc0fa133b4d09b33.tar.gz qemu-4a0117cf6e04d568a1963540bc0fa133b4d09b33.tar.bz2 | |
virtio: Free blk virqueues at unrealize()
The function virtio_del_queue was not called at unrealize() callback.
This was detected due to add an allocated element on the vq introduce
in future commits (used_elems) and running address sanitizer memory
leak detector.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Message-Id: <20191025083527.30803-4-eperezma@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/block/virtio-blk.c')
| -rw-r--r-- | hw/block/virtio-blk.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index ed2ddeb..ba846fe 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -1206,9 +1206,14 @@ static void virtio_blk_device_unrealize(DeviceState *dev, Error **errp) { VirtIODevice *vdev = VIRTIO_DEVICE(dev); VirtIOBlock *s = VIRTIO_BLK(dev); + VirtIOBlkConf *conf = &s->conf; + unsigned i; virtio_blk_data_plane_destroy(s->dataplane); s->dataplane = NULL; + for (i = 0; i < conf->num_queues; i++) { + virtio_del_queue(vdev, i); + } qemu_del_vm_change_state_handler(s->change); blockdev_mark_auto_del(s->blk); virtio_cleanup(vdev); |