diff options
| author | Markus Armbruster <armbru@redhat.com> | 2021-11-17 17:34:02 +0100 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2021-12-15 08:38:16 +0100 |
| commit | 8acf052f7a70df88c01feccd8992eb50afce1b1d (patch) | |
| tree | 1b18f38b21bfedf58441aa68d152aa0eeeae973b /hw/arm | |
| parent | 6b87668b0813b9cb5ec714dcbcd8f128cfc4a3b1 (diff) | |
| download | qemu-8acf052f7a70df88c01feccd8992eb50afce1b1d.zip qemu-8acf052f7a70df88c01feccd8992eb50afce1b1d.tar.gz qemu-8acf052f7a70df88c01feccd8992eb50afce1b1d.tar.bz2 | |
hw/arm/mcimx6ul-evk: Replace drive_get_next() by drive_get()
drive_get_next() is basically a bad idea. It returns the "next" block
backend of a certain interface type. "Next" means bus=0,unit=N, where
subsequent calls count N up from zero, per interface type.
This lets you define unit numbers implicitly by execution order. If the
order changes, or new calls appear "in the middle", unit numbers change.
ABI break. Hard to spot in review.
Machine "mcimx6ul-evk" connects backends with drive_get_next() in a
counting loop. Change it to use drive_get() directly. This makes the
unit numbers explicit in the code.
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Jean-Christophe Dubois <jcd@tribudubois.net>
Cc: qemu-arm@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20211117163409.3587705-7-armbru@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'hw/arm')
| -rw-r--r-- | hw/arm/mcimx6ul-evk.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/arm/mcimx6ul-evk.c b/hw/arm/mcimx6ul-evk.c index 77fae87..28b4886 100644 --- a/hw/arm/mcimx6ul-evk.c +++ b/hw/arm/mcimx6ul-evk.c @@ -52,7 +52,7 @@ static void mcimx6ul_evk_init(MachineState *machine) DriveInfo *di; BlockBackend *blk; - di = drive_get_next(IF_SD); + di = drive_get(IF_SD, 0, i); blk = di ? blk_by_legacy_dinfo(di) : NULL; bus = qdev_get_child_bus(DEVICE(&s->usdhc[i]), "sd-bus"); carddev = qdev_new(TYPE_SD_CARD); |