diff options
author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:50 +0200 |
---|---|---|
committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:31:52 +0200 |
commit | db725815985654007ade0fd53590d613fd657208 (patch) | |
tree | e39bcf77a808fa0002cea415b2a487cf5c7eaf4b /hw/9pfs | |
parent | dc5e9ac716c5c5312ab29fb9f311f8176064fe04 (diff) | |
download | qemu-db725815985654007ade0fd53590d613fd657208.zip qemu-db725815985654007ade0fd53590d613fd657208.tar.gz qemu-db725815985654007ade0fd53590d613fd657208.tar.bz2 |
Include qemu/main-loop.h less
In my "build everything" tree, changing qemu/main-loop.h triggers a
recompile of some 5600 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h). It includes block/aio.h,
which in turn includes qemu/event_notifier.h, qemu/notify.h,
qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h,
qemu/thread.h, qemu/timer.h, and a few more.
Include qemu/main-loop.h only where it's needed. Touching it now
recompiles only some 1700 objects. For block/aio.h and
qemu/event_notifier.h, these numbers drop from 5600 to 2800. For the
others, they shrink only slightly.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190812052359.30071-21-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'hw/9pfs')
-rw-r--r-- | hw/9pfs/9p.c | 1 | ||||
-rw-r--r-- | hw/9pfs/codir.c | 1 | ||||
-rw-r--r-- | hw/9pfs/cofile.c | 1 | ||||
-rw-r--r-- | hw/9pfs/cofs.c | 1 | ||||
-rw-r--r-- | hw/9pfs/coth.c | 1 | ||||
-rw-r--r-- | hw/9pfs/coth.h | 1 | ||||
-rw-r--r-- | hw/9pfs/coxattr.c | 1 | ||||
-rw-r--r-- | hw/9pfs/xen-9p-backend.c | 1 |
8 files changed, 7 insertions, 1 deletions
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 5582134..cce2366 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -17,6 +17,7 @@ #include "qapi/error.h" #include "qemu/error-report.h" #include "qemu/iov.h" +#include "qemu/main-loop.h" #include "qemu/sockets.h" #include "virtio-9p.h" #include "fsdev/qemu-fsdev.h" diff --git a/hw/9pfs/codir.c b/hw/9pfs/codir.c index 7cd6fce..73f9a75 100644 --- a/hw/9pfs/codir.c +++ b/hw/9pfs/codir.c @@ -15,6 +15,7 @@ #include "fsdev/qemu-fsdev.h" #include "qemu/thread.h" #include "qemu/coroutine.h" +#include "qemu/main-loop.h" #include "coth.h" int coroutine_fn v9fs_co_readdir(V9fsPDU *pdu, V9fsFidState *fidp, diff --git a/hw/9pfs/cofile.c b/hw/9pfs/cofile.c index 9c22837..83bb6c1 100644 --- a/hw/9pfs/cofile.c +++ b/hw/9pfs/cofile.c @@ -15,6 +15,7 @@ #include "fsdev/qemu-fsdev.h" #include "qemu/thread.h" #include "qemu/coroutine.h" +#include "qemu/main-loop.h" #include "coth.h" int coroutine_fn v9fs_co_st_gen(V9fsPDU *pdu, V9fsPath *path, mode_t st_mode, diff --git a/hw/9pfs/cofs.c b/hw/9pfs/cofs.c index c621032..5599191 100644 --- a/hw/9pfs/cofs.c +++ b/hw/9pfs/cofs.c @@ -15,6 +15,7 @@ #include "fsdev/qemu-fsdev.h" #include "qemu/thread.h" #include "qemu/coroutine.h" +#include "qemu/main-loop.h" #include "coth.h" static ssize_t __readlink(V9fsState *s, V9fsPath *path, V9fsString *buf) diff --git a/hw/9pfs/coth.c b/hw/9pfs/coth.c index c3b4336..9778f24 100644 --- a/hw/9pfs/coth.c +++ b/hw/9pfs/coth.c @@ -15,6 +15,7 @@ #include "qemu/osdep.h" #include "block/thread-pool.h" #include "qemu/coroutine.h" +#include "qemu/main-loop.h" #include "coth.h" /* Called from QEMU I/O thread. */ diff --git a/hw/9pfs/coth.h b/hw/9pfs/coth.h index 19e4d92..c2cdc7a 100644 --- a/hw/9pfs/coth.h +++ b/hw/9pfs/coth.h @@ -17,7 +17,6 @@ #include "qemu/thread.h" #include "qemu/coroutine.h" -#include "qemu/main-loop.h" #include "9p.h" /* diff --git a/hw/9pfs/coxattr.c b/hw/9pfs/coxattr.c index 154392e..0e00ffa 100644 --- a/hw/9pfs/coxattr.c +++ b/hw/9pfs/coxattr.c @@ -15,6 +15,7 @@ #include "fsdev/qemu-fsdev.h" #include "qemu/thread.h" #include "qemu/coroutine.h" +#include "qemu/main-loop.h" #include "coth.h" int coroutine_fn v9fs_co_llistxattr(V9fsPDU *pdu, V9fsPath *path, void *value, diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c index c50b196..71eebe1 100644 --- a/hw/9pfs/xen-9p-backend.c +++ b/hw/9pfs/xen-9p-backend.c @@ -15,6 +15,7 @@ #include "hw/9pfs/xen-9pfs.h" #include "qapi/error.h" #include "qemu/config-file.h" +#include "qemu/main-loop.h" #include "qemu/option.h" #include "fsdev/qemu-fsdev.h" |