aboutsummaryrefslogtreecommitdiff
path: root/hmp.c
diff options
context:
space:
mode:
authorJuan Quintela <quintela@redhat.com>2019-04-03 13:49:51 +0200
committerDr. David Alan Gilbert <dgilbert@redhat.com>2019-04-05 15:32:13 +0100
commitd013283a46e1f197594e76ed320f867067ab80b3 (patch)
tree5d96aad165c6ce872f1182856570dbfa9d594afc /hmp.c
parentc6e5bafb6ff330e972eae7b823321143ab3e29e2 (diff)
downloadqemu-d013283a46e1f197594e76ed320f867067ab80b3.zip
qemu-d013283a46e1f197594e76ed320f867067ab80b3.tar.gz
qemu-d013283a46e1f197594e76ed320f867067ab80b3.tar.bz2
migration: Fix migrate_set_parameter
Otherwise we are setting err twice, what is wrong and causes an abort. Signed-off-by: Juan Quintela <quintela@redhat.com> Message-Id: <20190403114958.3705-2-quintela@redhat.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Diffstat (limited to 'hmp.c')
-rw-r--r--hmp.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/hmp.c b/hmp.c
index 9294114..8eec768 100644
--- a/hmp.c
+++ b/hmp.c
@@ -1825,8 +1825,10 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
case MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE:
p->has_xbzrle_cache_size = true;
visit_type_size(v, param, &cache_size, &err);
- if (err || cache_size > INT64_MAX
- || (size_t)cache_size != cache_size) {
+ if (err) {
+ break;
+ }
+ if (cache_size > INT64_MAX || (size_t)cache_size != cache_size) {
error_setg(&err, "Invalid size %s", valuestr);
break;
}