diff options
| author | Andrew Burgess <aburgess@redhat.com> | 2022-08-31 09:41:23 +0100 |
|---|---|---|
| committer | Alistair Francis <alistair@alistair23.me> | 2022-09-27 07:04:38 +1000 |
| commit | 4c0f0b6619126637e802f07c9fe8e9fffbc1c4bb (patch) | |
| tree | e786058e3f47e69ec54c86019f0bc9919a4bdd4c /gdb-xml | |
| parent | 94452ac4cf263e8996613db8d981e4ea85bd019a (diff) | |
| download | qemu-4c0f0b6619126637e802f07c9fe8e9fffbc1c4bb.zip qemu-4c0f0b6619126637e802f07c9fe8e9fffbc1c4bb.tar.gz qemu-4c0f0b6619126637e802f07c9fe8e9fffbc1c4bb.tar.bz2 | |
target/riscv: remove fixed numbering from GDB xml feature files
The fixed register numbering in the various GDB feature files for
RISC-V only exists because these files were originally copied from the
GDB source tree.
However, the fixed numbering only exists in the GDB source tree so
that GDB, when it connects to a target that doesn't provide a target
description, will use a specific numbering scheme.
That numbering scheme is designed to be compatible with the first
versions of QEMU (for RISC-V), that didn't send a target description,
and relied on a fixed numbering scheme.
Because of the way that QEMU manages its target descriptions,
recording the number of registers in each feature, and just relying on
GDB's numbering starting from 0, then I propose that we remove all the
fixed numbering from the RISC-V feature xml files, and just rely on
the standard numbering scheme. Plenty of other targets manage their
xml files this way, e.g. ARM, AArch64, Loongarch, m68k, rx, and s390.
Signed-off-by: Andrew Burgess <aburgess@redhat.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
Message-Id: <6069395f90e6fc24dac92197be815fedf42f5974.1661934573.git.aburgess@redhat.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Diffstat (limited to 'gdb-xml')
| -rw-r--r-- | gdb-xml/riscv-32bit-cpu.xml | 6 | ||||
| -rw-r--r-- | gdb-xml/riscv-32bit-fpu.xml | 6 | ||||
| -rw-r--r-- | gdb-xml/riscv-64bit-cpu.xml | 6 | ||||
| -rw-r--r-- | gdb-xml/riscv-64bit-fpu.xml | 6 |
4 files changed, 4 insertions, 20 deletions
diff --git a/gdb-xml/riscv-32bit-cpu.xml b/gdb-xml/riscv-32bit-cpu.xml index 0d07aae..466f2c0 100644 --- a/gdb-xml/riscv-32bit-cpu.xml +++ b/gdb-xml/riscv-32bit-cpu.xml @@ -5,13 +5,9 @@ are permitted in any medium without royalty provided the copyright notice and this notice are preserved. --> -<!-- Register numbers are hard-coded in order to maintain backward - compatibility with older versions of tools that didn't use xml - register descriptions. --> - <!DOCTYPE feature SYSTEM "gdb-target.dtd"> <feature name="org.gnu.gdb.riscv.cpu"> - <reg name="zero" bitsize="32" type="int" regnum="0"/> + <reg name="zero" bitsize="32" type="int"/> <reg name="ra" bitsize="32" type="code_ptr"/> <reg name="sp" bitsize="32" type="data_ptr"/> <reg name="gp" bitsize="32" type="data_ptr"/> diff --git a/gdb-xml/riscv-32bit-fpu.xml b/gdb-xml/riscv-32bit-fpu.xml index 84a44ba..24aa087 100644 --- a/gdb-xml/riscv-32bit-fpu.xml +++ b/gdb-xml/riscv-32bit-fpu.xml @@ -5,13 +5,9 @@ are permitted in any medium without royalty provided the copyright notice and this notice are preserved. --> -<!-- Register numbers are hard-coded in order to maintain backward - compatibility with older versions of tools that didn't use xml - register descriptions. --> - <!DOCTYPE feature SYSTEM "gdb-target.dtd"> <feature name="org.gnu.gdb.riscv.fpu"> - <reg name="ft0" bitsize="32" type="ieee_single" regnum="33"/> + <reg name="ft0" bitsize="32" type="ieee_single"/> <reg name="ft1" bitsize="32" type="ieee_single"/> <reg name="ft2" bitsize="32" type="ieee_single"/> <reg name="ft3" bitsize="32" type="ieee_single"/> diff --git a/gdb-xml/riscv-64bit-cpu.xml b/gdb-xml/riscv-64bit-cpu.xml index b8aa424..c4d83de 100644 --- a/gdb-xml/riscv-64bit-cpu.xml +++ b/gdb-xml/riscv-64bit-cpu.xml @@ -5,13 +5,9 @@ are permitted in any medium without royalty provided the copyright notice and this notice are preserved. --> -<!-- Register numbers are hard-coded in order to maintain backward - compatibility with older versions of tools that didn't use xml - register descriptions. --> - <!DOCTYPE feature SYSTEM "gdb-target.dtd"> <feature name="org.gnu.gdb.riscv.cpu"> - <reg name="zero" bitsize="64" type="int" regnum="0"/> + <reg name="zero" bitsize="64" type="int"/> <reg name="ra" bitsize="64" type="code_ptr"/> <reg name="sp" bitsize="64" type="data_ptr"/> <reg name="gp" bitsize="64" type="data_ptr"/> diff --git a/gdb-xml/riscv-64bit-fpu.xml b/gdb-xml/riscv-64bit-fpu.xml index 9856a9d..d0f17f9 100644 --- a/gdb-xml/riscv-64bit-fpu.xml +++ b/gdb-xml/riscv-64bit-fpu.xml @@ -5,10 +5,6 @@ are permitted in any medium without royalty provided the copyright notice and this notice are preserved. --> -<!-- Register numbers are hard-coded in order to maintain backward - compatibility with older versions of tools that didn't use xml - register descriptions. --> - <!DOCTYPE feature SYSTEM "gdb-target.dtd"> <feature name="org.gnu.gdb.riscv.fpu"> @@ -17,7 +13,7 @@ <field name="double" type="ieee_double"/> </union> - <reg name="ft0" bitsize="64" type="riscv_double" regnum="33"/> + <reg name="ft0" bitsize="64" type="riscv_double"/> <reg name="ft1" bitsize="64" type="riscv_double"/> <reg name="ft2" bitsize="64" type="riscv_double"/> <reg name="ft3" bitsize="64" type="riscv_double"/> |