diff options
| author | Markus Armbruster <armbru@redhat.com> | 2018-10-17 10:26:55 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2018-10-19 14:51:34 +0200 |
| commit | b836723dfe642a67904bcd047feaaa0cda662d38 (patch) | |
| tree | ee4fa92c0153cc6a85eaa2b6277189f99b0bed7e /fsdev/qemu-fsdev.h | |
| parent | 9338570b7b0b8890269222b7b40e0b819f824dab (diff) | |
| download | qemu-b836723dfe642a67904bcd047feaaa0cda662d38.zip qemu-b836723dfe642a67904bcd047feaaa0cda662d38.tar.gz qemu-b836723dfe642a67904bcd047feaaa0cda662d38.tar.bz2 | |
fsdev: Clean up error reporting in qemu_fsdev_add()
Calling error_report() from within a function that takes an Error **
argument is suspicious. qemu_fsdev_add() does that, and its caller
fsdev_init_func() then fails without setting an error. Its caller
main(), via qemu_opts_foreach(), is fine with it, but clean it up
anyway.
Cc: Greg Kurz <groug@kaod.org>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Greg Kurz <groug@kaod.org>
Message-Id: <20181017082702.5581-32-armbru@redhat.com>
Diffstat (limited to 'fsdev/qemu-fsdev.h')
| -rw-r--r-- | fsdev/qemu-fsdev.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fsdev/qemu-fsdev.h b/fsdev/qemu-fsdev.h index 65e4b1c..d9716b4 100644 --- a/fsdev/qemu-fsdev.h +++ b/fsdev/qemu-fsdev.h @@ -38,7 +38,7 @@ typedef struct FsDriverListEntry { QTAILQ_ENTRY(FsDriverListEntry) next; } FsDriverListEntry; -int qemu_fsdev_add(QemuOpts *opts); +int qemu_fsdev_add(QemuOpts *opts, Error **errp); FsDriverEntry *get_fsdev_fsentry(char *id); extern FileOperations local_ops; extern FileOperations handle_ops; |